Closed
Conversation
Creates a dedicated function for the menu's bordered render code Switches speedrun timer to use it and moves down its render layer
Contributor
Author
|
Added a border for better contrast, and lowered its order in rendering (so it renders over more things).
|
Contributor
Author
|
This has some subtle timing issues that are difficult to fix without the code involved in managing the timer ballooning in size. Closing in favor of #48 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Been doing some speedruns again recently and missed the in-game timer from the tasb0t mod, thought I'd recreate it (all my own code) and PR it. Initial draft of this was pretty conservative about when to tick the timer (basically mirroring the vanilla/SMB timer) but this would've excluded things like fireworks and pipe animations from the time which I think should be timed to better incentivize clever routing. So basically the only thing not counted towards the timer now is the level loading screens. Some sample footage attempting to highlight all the minutia can be found below.
2023-06-25_00-47-52.mp4