-
Notifications
You must be signed in to change notification settings - Fork 100
feat(button) - update button base styles for SHINE #2008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ttaylor-stack
merged 38 commits into
beta
from
spark-55/shine-update-button-base-styles
Nov 21, 2025
+6,758
−5,466
Merged
Changes from 4 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
81048cb
Merge branch 'develop' into spark-55/shine-update-button-base-styles
ttaylor-stack 643ba84
update default and xs
ttaylor-stack 775b57e
Update button.less
ttaylor-stack 1c40dc1
Update based on changes
ttaylor-stack cf1c920
Merge branch 'spark-55/shine-update-button-base-styles' of https://gi…
ttaylor-stack 7f2cde6
fix duplicate
ttaylor-stack f2bafc7
Merge branch 'beta' into spark-55/shine-update-button-base-styles
ttaylor-stack 03be402
Merge branch 'beta' into spark-55/shine-update-button-base-styles
ttaylor-stack 7836b23
Update button.less
ttaylor-stack 4aa9ee4
update docs
ttaylor-stack 908c113
update button svelte files
ttaylor-stack 553be5f
add changeset
ttaylor-stack 5bacf2a
update dependent svelte files
ttaylor-stack 3864d59
update to theme secondary
ttaylor-stack ecda33e
Update accessibility tests
ttaylor-stack 0cff80e
remove contextual styles
ttaylor-stack c43816f
reintroduce contextual styles
ttaylor-stack dfd0139
Merge branch 'beta' into spark-55/shine-update-button-base-styles
ttaylor-stack 16d5cde
Update based on figma update and pr comments
ttaylor-stack 965c54c
Update badge background color for danger clear variant
ttaylor-stack 9db5f52
add breaking changes
ttaylor-stack 69ec77a
Update docs
ttaylor-stack a9b255e
correct gradients
ttaylor-stack 850fdf3
use color instead of opacity
ttaylor-stack e0719f3
Update based on comments
ttaylor-stack 6cce94a
Merge branch 'beta' into spark-55/shine-update-button-base-styles
ttaylor-stack 4fe49e2
Button styles refactor (#2052)
dancormier bcb6f21
update svelte component
ttaylor-stack bb0d4db
Merge branch 'beta' into spark-55/shine-update-button-base-styles
ttaylor-stack b7c8122
Update migration guide
ttaylor-stack af6aacb
fix lint issue
ttaylor-stack 3ecdc69
Merge branch 'beta' into spark-55/shine-update-button-base-styles
ttaylor-stack 991e62e
Fix button prop in Menu story
dancormier 4a428f2
update visual tests
ttaylor-stack 2ab5354
updsate visual tests
ttaylor-stack 57b422d
update visual regression tests
ttaylor-stack f8d8bbc
Merge branch 'beta' into spark-55/shine-update-button-base-styles
dancormier 290432f
Update visual regression images
dancormier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| import path from "path" | ||
| import MiniCssExtractPlugin from 'mini-css-extract-plugin'; | ||
| import cssnano from 'cssnano' | ||
| import { fileURLToPath } from 'node:url'; | ||
| import { dirname } from 'node:path'; | ||
|
|
||
| const __filename = fileURLToPath(import.meta.url); | ||
| const __dirname = dirname(__filename); | ||
|
|
||
| const tsRule = (configFile) => ({ | ||
| test: /\.tsx?$/, | ||
| exclude: /node_modules/, | ||
| use: [ | ||
| { | ||
| loader: "ts-loader", | ||
| options: configFile ? { configFile } : {}, | ||
| }, | ||
| ], | ||
| }); | ||
|
|
||
| const lessRule = (minify = false) => ({ | ||
| test: /\.less$/, | ||
| use: [ | ||
| MiniCssExtractPlugin.loader, | ||
| { | ||
| loader: "css-loader", | ||
| options: { | ||
| importLoaders: 1, | ||
| url: false, | ||
| }, | ||
| }, | ||
| { | ||
| loader: "postcss-loader", | ||
| options: { | ||
| postcssOptions: { | ||
| plugins: minify ? [cssnano] : [], | ||
| }, | ||
| }, | ||
| }, | ||
| "less-loader", | ||
| ], | ||
| }); | ||
|
|
||
| const commonResolve = { | ||
| extensions: [".tsx", ".ts", ".js"], | ||
| }; | ||
|
|
||
| const baseConfig = (isProd, minify) => ({ | ||
| name: "stacks" + (minify ? ".min" : ""), | ||
| // run the minified bundle first, then the unminified bundle | ||
| dependencies: minify ? [] : ["stacks.min"], | ||
| mode: isProd ? "production" : "development", | ||
| devtool: isProd ? false : "inline-source-map", | ||
| entry: { | ||
| // add .min to the file names of minified bundles | ||
| [minify ? "stacks.min" : "stacks"]: path.resolve( | ||
| __dirname, | ||
| "lib/index.ts" | ||
| ), | ||
| }, | ||
| output: { | ||
| filename: `js/[name].js`, | ||
| path: path.resolve(__dirname, "dist"), | ||
| // don't empty out the dist folder when running the second build | ||
| clean: minify, | ||
| compareBeforeEmit: true, | ||
| library: "Stacks", | ||
| libraryTarget: "umd", | ||
| }, | ||
| module: { | ||
| rules: [tsRule("tsconfig.build.json"), lessRule(minify)], | ||
| }, | ||
| optimization: { | ||
| minimize: minify, | ||
| }, | ||
| plugins: [ | ||
| new MiniCssExtractPlugin({ | ||
| filename: `css/[name].css`, | ||
| }), | ||
| ], | ||
| resolve: commonResolve, | ||
| }); | ||
|
|
||
| export { tsRule, lessRule, commonResolve }; | ||
|
|
||
| // build the bundle twice - once minified and once not | ||
| export default [ | ||
| (_, argv) => baseConfig(argv.mode === "production", true), | ||
| (_, argv) => baseConfig(argv.mode === "production", false), | ||
| ]; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.