-
Notifications
You must be signed in to change notification settings - Fork 100
feat(input) - update radio and checkbox components for shine #2060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ttaylor-stack
wants to merge
14
commits into
beta
Choose a base branch
from
spark-77/update-radio-and-checkbox-components-for-shine
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
14c97c4
Update docs - TEMP change
ttaylor-stack 9b03f7f
add checkmark class
ttaylor-stack 857281c
update docs
ttaylor-stack 36c0a64
Add radio svelte component
ttaylor-stack 3941c59
Add Checkbox and Checkmark svelte components
ttaylor-stack 27edd5d
add changeset
ttaylor-stack 497dc04
fix tests
ttaylor-stack eb703e1
Merge branch 'beta' into spark-77/update-radio-and-checkbox-component…
ttaylor-stack 2be8337
remove todo
ttaylor-stack 76257a4
use black-300 instead of opacity for checkmark
ttaylor-stack 0abee85
update a11y and visual tests
ttaylor-stack 1a15deb
Update site-navigation.json
ttaylor-stack 68dabc4
Merge branch 'spark-77/update-radio-and-checkbox-components-for-shine…
ttaylor-stack ee22c2b
update tests
ttaylor-stack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| "@stackoverflow/stacks": minor | ||
| "@stackoverflow/stacks-svelte": minor | ||
| --- | ||
|
|
||
| Updated checkbox and radio styling in Stacks Classic and documentation for SHINE. | ||
| Added s-checkmark and s-check-control__checkmark to Stacks Classic | ||
| Added Radio, Checkbox, and Checkmark components to Stacks Svelte |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...es/stacks-classic/screenshots/Chromium/baseline/s-check-control-dark-checked-checkbox.ico
Git LFS file not shown
4 changes: 2 additions & 2 deletions
4
packages/stacks-classic/screenshots/Chromium/baseline/s-check-control-dark-checked-radio.ico
Git LFS file not shown
4 changes: 2 additions & 2 deletions
4
...classic/screenshots/Chromium/baseline/s-check-control-dark-has-error-checked-checkbox.ico
Git LFS file not shown
4 changes: 2 additions & 2 deletions
4
...ks-classic/screenshots/Chromium/baseline/s-check-control-dark-has-error-checked-radio.ico
Git LFS file not shown
4 changes: 2 additions & 2 deletions
4
...assic/screenshots/Chromium/baseline/s-check-control-dark-has-error-unchecked-checkbox.ico
Git LFS file not shown
4 changes: 2 additions & 2 deletions
4
...-classic/screenshots/Chromium/baseline/s-check-control-dark-has-error-unchecked-radio.ico
Git LFS file not shown
4 changes: 2 additions & 2 deletions
4
...assic/screenshots/Chromium/baseline/s-check-control-dark-has-success-checked-checkbox.ico
Git LFS file not shown
4 changes: 2 additions & 2 deletions
4
...-classic/screenshots/Chromium/baseline/s-check-control-dark-has-success-checked-radio.ico
Git LFS file not shown
4 changes: 2 additions & 2 deletions
4
...sic/screenshots/Chromium/baseline/s-check-control-dark-has-success-unchecked-checkbox.ico
Git LFS file not shown
4 changes: 2 additions & 2 deletions
4
...lassic/screenshots/Chromium/baseline/s-check-control-dark-has-success-unchecked-radio.ico
Git LFS file not shown
4 changes: 2 additions & 2 deletions
4
...assic/screenshots/Chromium/baseline/s-check-control-dark-has-warning-checked-checkbox.ico
Git LFS file not shown
4 changes: 2 additions & 2 deletions
4
...-classic/screenshots/Chromium/baseline/s-check-control-dark-has-warning-checked-radio.ico
Git LFS file not shown
4 changes: 2 additions & 2 deletions
4
...sic/screenshots/Chromium/baseline/s-check-control-dark-has-warning-unchecked-checkbox.ico
Git LFS file not shown
4 changes: 2 additions & 2 deletions
4
...lassic/screenshots/Chromium/baseline/s-check-control-dark-has-warning-unchecked-radio.ico
Git LFS file not shown
4 changes: 2 additions & 2 deletions
4
.../stacks-classic/screenshots/Chromium/baseline/s-check-control-dark-unchecked-checkbox.ico
Git LFS file not shown
4 changes: 2 additions & 2 deletions
4
...ges/stacks-classic/screenshots/Chromium/baseline/s-check-control-dark-unchecked-radio.ico
Git LFS file not shown
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added this instead of checking against child elements because I thought it would be cleaner, let me know if I should change this