Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions packages/stacks-svelte/src/components/Popover/Popover.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,57 @@ describe("Popover", () => {
);
});

it("override classes to the popover content inner div when the innerContentClassOverride prop is provided", async () => {
const { container } = render(Popover, {
props: {
...defaultProps,
autoshow: true,
children: createSvelteComponentsSnippet([
defaultChildren.reference,
{
component: PopoverContent,
props: {
innerContentClassOverride: "custom-class",
children: createRawSnippet(() => ({
render: () => "<span>Popover Content</span>",
})),
},
},
]),
},
});

const innerContentElement = container.querySelector(
".s-popover--content"
);

expect(innerContentElement).to.exist;
expect(innerContentElement).to.have.class("custom-class");
expect(innerContentElement).not.to.have.class("p12");
expect(innerContentElement).not.to.have.class("mn12");
});

it("popover content inner div should contain default classes when innerContentClassOverride prop is not provided", async () => {
const { container } = render(Popover, {
props: {
...defaultProps,
autoshow: true,
children: createSvelteComponentsSnippet([
defaultChildren.reference,
defaultChildren.content,
]),
},
});

const innerContentElement = container.querySelector(
".s-popover--content"
);

expect(innerContentElement).to.exist;
expect(innerContentElement).to.have.class("p12");
expect(innerContentElement).to.have.class("mn12");
});

it("should hide the popover content when the user click outside the popover", async () => {
render(Popover, {
props: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,22 @@
* Additional CSS classes added to the element
*/
class?: string;
/**
* Override the default inner content class
*/
innerContentClassOverride?: string | null;
/**
* Children snippet
*/
children?: Snippet;
}

let { role = null, class: className = "", children }: Props = $props();
let {
role = null,
class: className = "",
innerContentClassOverride = null,
children,
}: Props = $props();

let pstate = usePopoverContext("PopoverContent");

Expand All @@ -34,6 +43,16 @@
return result;
});

let innerContentClass = $derived.by(() => {
let result = "s-popover--content ";
if (innerContentClassOverride != null) {
result += innerContentClassOverride;
} else {
result += "p12 mn12";
}
return result;
});

let computedClass = $derived(
`${classes}${pstate.visible ? " is-visible" : ""}`
);
Expand All @@ -58,7 +77,7 @@
onfocusout={pstate.closeTooltip}
data-popper-placement={pstate.computedPlacement}
>
<div class="s-popover--content p12 mn12">
<div class={innerContentClass}>
<div class="ps-relative">
{@render children?.()}
</div>
Expand Down