Skip to content

Conversation

@mukunku
Copy link
Collaborator

@mukunku mukunku commented Jan 9, 2026

Summary

This PR Updates the Banner component styles to match the latest SHINE designs: https://www.figma.com/design/do4Ug0Yws8xCfRjHe9cJfZ/Project-SHINE---Product-UI?node-id=5982-7648&m=dev

This PR should be merged after #2109

How to Test

Check out the Banner component: https://deploy-preview-2118--stacks.netlify.app/product/components/banners/

There is no Svelte component for banners.

@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2026

🦋 Changeset detected

Latest commit: 6af2a5a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 9, 2026

Deploy Preview for stacks-svelte ready!

Name Link
🔨 Latest commit 6af2a5a
🔍 Latest deploy log https://app.netlify.com/projects/stacks-svelte/deploys/69616a29f89bc50008133525
😎 Deploy Preview https://deploy-preview-2118--stacks-svelte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mukunku mukunku changed the base branch from develop to sal/SPARK-72 January 9, 2026 14:10
@netlify
Copy link

netlify bot commented Jan 9, 2026

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit 6af2a5a
🔍 Latest deploy log https://app.netlify.com/projects/stacks/deploys/69616a29b3d4bb0008e6ac43
😎 Deploy Preview https://deploy-preview-2118--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mukunku mukunku marked this pull request as ready for review January 9, 2026 17:06
@mukunku mukunku changed the base branch from sal/SPARK-72 to beta January 9, 2026 17:06
@mukunku mukunku changed the base branch from beta to sal/SPARK-72 January 9, 2026 17:11
@mukunku mukunku requested a review from CGuindon January 9, 2026 18:04
@mukunku mukunku changed the base branch from sal/SPARK-72 to beta January 9, 2026 18:11
@mukunku mukunku changed the base branch from beta to sal/SPARK-72 January 9, 2026 18:11
@mukunku mukunku changed the base branch from sal/SPARK-72 to beta January 9, 2026 18:12
@mukunku mukunku added the do-not-merge Pull requests that are in progress and should not be merged yet label Jan 9, 2026
@mukunku
Copy link
Collaborator Author

mukunku commented Jan 9, 2026

This should be ready for review @CGuindon ! Let me know what you think 🙏🏾

I also saw your comment about maybe removing the pinned option. Didn't know if we should do that so I kept it for now.

Copy link
Collaborator

@CGuindon CGuindon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2026-01-09 at 10 48 22 AM

When I fixed the ellipsis icon to be the Cross, I noticed it had also reverted to it's default #000 everywhere. I fixed this morning as well in the Figma, for the Important variants, the Cross/X icon should be white like the text (to pass a11y) — except for yellow/warning.

@mukunku
Copy link
Collaborator Author

mukunku commented Jan 9, 2026

When I fixed the ellipsis icon to be the Cross, I noticed it had also reverted to it's default #000 everywhere. I fixed this morning as well in the Figma, for the Important variants, the Cross/X icon should be white like the text (to pass a11y) — except for yellow/warning.

I think that was an oversight by me. It should be fixed now @CGuindon 👍🏾

@mukunku mukunku requested a review from CGuindon January 9, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge Pull requests that are in progress and should not be merged yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants