Skip to content

Conversation

@chicks-net
Copy link
Collaborator

@chicks-net chicks-net commented Dec 1, 2025

Done

  • [docs] Refresh digital ocean provider docs by clarifying which record types are supported, linking to the digital ocean docs, and calling out other relevant internal docs.
  • spelling correction
  • update docs for chicks-net as maintainer for digital ocean

Meta

(Automated in .just/gh-process.just.)

@tlimoncelli tlimoncelli requested a review from cafferata December 1, 2025 13:54
```
{% endcode %}

The [creds.json](/commands/creds.json#example-commands) page in the docs explains how you can generate this dynamically so you can pull the secret token from 1Password or the vault of your choosing.

This comment was marked as resolved.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this. I've tried a variety of relative incantations and none seem to work so far. I feel like ../commands/creds-json#example-commands should work - see https://docs.dnscontrol.org/~/revisions/0Am6Ovu9k4Q2mNtPFZC6/provider/digitalocean and b142af2 for it not working.

I might try a few more combinations, but I'm out of ideas.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally found the right combination when I found an example. I was having trouble finding an example because noone else is referring directly to the commands directory.

Is there any more that should be done for this PR?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that was all.


This means that `ALIAS`, `DHCID`, `DNAME`, `DS`, `FRAME`, `HTTPS`, `LOC`, `OPENPGPKEY`, `PTR`, `SMIMEA`, `SSHFP`, `SVCB`, `TLSA`, `URL`, or `URL301` presumably **do not work** with Digital Ocean.

In 2025, the provider maintainer has confirmed that `ALIAS` and `LOC` records are rejected. The other ones that do not work are expected in this circumstance. `SPF` records are not a problem since they are turned into `TXT` record types.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These rejects could/should be added to

func AuditRecords(records []*models.RecordConfig) []error {

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely agree that some of this research needs to get carried over into code. I'm planning on circling back with that soon. I'm still trying to figure out what the code-level priorities should be to have this provider following the project's best practices. 😁

@chicks-net
Copy link
Collaborator Author

@tlimoncelli @cafferata am I supposed to merge this? I don't seem to have that ability.

@tlimoncelli
Copy link
Collaborator

@tlimoncelli @cafferata am I supposed to merge this? I don't seem to have that ability.

I do the merging. :)

I assume something is ready to merge once it is no longer in "draft" mode and has the appropriate approvals. (We should probably document that.)

@tlimoncelli tlimoncelli merged commit db27a1e into StackExchange:main Dec 8, 2025
5 of 6 checks passed
@tlimoncelli tlimoncelli changed the title [docs] Refresh digital ocean provider docs DIGITALOCEAN: DOCS: Refresh digital ocean provider docs Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants