Skip to content

BUNNYDNS: Permit SRV "." targets #4003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlimoncelli merged 1 commit into from
Jan 24, 2026
+8 −4
Merged

BUNNYDNS: Permit SRV "." targets #4003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions providers/bunnydns/auditrecords.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ import (
// supported, an empty list is returned.
func AuditRecords(records []*models.RecordConfig) []error {
a := rejectif.Auditor{}
a.Add("TXT", rejectif.TxtIsEmpty) // Last verified 2024-01-02
a.Add("SRV", rejectif.SrvHasNullTarget) // Last verified 2024-01-02
a.Add("TXT", rejectif.TxtIsEmpty) // Last verified 2024-01-02

return a.Audit(records)
}
9 changes: 7 additions & 2 deletions providers/bunnydns/convert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,16 @@ func fromRecordConfig(rc *models.RecordConfig) (*record, error) {
r.Value = strings.TrimSuffix(r.Value, ".")
}

// In the case of SVCB/HTTPS records, the Target is part of the Value.
// After removing trailing dots for said target, we can add the params to the value.
switch r.Type {
case recordTypeSVCB, recordTypeHTTPS:
// In the case of SVCB/HTTPS records, the Target is part of the Value.
// After removing trailing dots for said target, we can add the params to the value.
r.Value = fmt.Sprintf("%s %s", r.Value, rc.SvcParams)
case recordTypeSRV:
// SRV empty target is represented as "."
if r.Value == "" {
r.Value = "."
}
}

return &r, nil
Expand Down
Loading