Skip to content

CICD: only run GHA release_draft on the main repo#4172

Closed
chicks-net wants to merge 1 commit intoStackExchange:mainfrom
chicks-net:chicks/2026-03-17-release-only-in-stackexchange
Closed

CICD: only run GHA release_draft on the main repo#4172
chicks-net wants to merge 1 commit intoStackExchange:mainfrom
chicks-net:chicks/2026-03-17-release-only-in-stackexchange

Conversation

@chicks-net
Copy link
Collaborator

@chicks-net chicks-net commented Mar 17, 2026

Context

When I sync'd the dnscontrol repo into my forked repo it reran these jobs. The jobs all fail since the credentials are not available.

This also ended up reformatting the yaml. Let me know if that is an issue.

Done

  • 🛶 only run GHA release_draft on the main repo

Meta

(Automated in .just/gh-process.just.)

@chicks-net chicks-net changed the title 🛶 only run GHA release_draft on the main repo CICD: only run GHA release_draft on the main repo Mar 17, 2026
@chicks-net chicks-net added the build Pull requests that updates CI code label Mar 17, 2026
Copy link
Collaborator

@cafferata cafferata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! The if: github.repository == 'StackExchange/dnscontrol' guard makes sense.

Could you resubmit without the indentation/quote reformatting? The rest of the workflow files in this repo use 2-space indentation and double quotes. Keeping just the one-line if: addition would make the diff much easier to review and stay consistent with the other files.

@chicks-net chicks-net marked this pull request as draft March 18, 2026 16:11
@chicks-net
Copy link
Collaborator Author

Thanks for the fix! The if: github.repository == 'StackExchange/dnscontrol' guard makes sense.

Could you resubmit without the indentation/quote reformatting? The rest of the workflow files in this repo use 2-space indentation and double quotes. Keeping just the one-line if: addition would make the diff much easier to review and stay consistent with the other files.

Totally makes sense. Will do.

@chicks-net
Copy link
Collaborator Author

Given #4174 this is going to need to be redone once we move the repo so I'm closing this for now and I'll make a new PR for the new home.

@chicks-net chicks-net closed this Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Pull requests that updates CI code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants