Skip to content

refactor(lint): replace typecheck with oxlint --type-check #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryoppippi merged 4 commits into from
Dec 10, 2025
Merged

refactor(lint): replace typecheck with oxlint --type-check #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d992c2
refactor(lint): replace typecheck with oxlint --type-check
ryoppippi Dec 10, 2025
825a557
chore(knip): ignore @typescript/native-preview
ryoppippi Dec 10, 2025
439e312
ci: remove obsolete typecheck step from CI workflow
ryoppippi Dec 10, 2025
f2338ea
chore(hooks): add knip check to push hook
ryoppippi Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ jobs:
- name: Run Lint
run: nix develop --command pnpm run lint

- name: Run Type Check
run: nix develop --command pnpm run typecheck

- name: Run Build
run: nix develop --command pnpm run build

Expand Down
3 changes: 2 additions & 1 deletion examples/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
"private": true,
"type": "module",
"scripts": {
"typecheck": "tsgo --noEmit"
"lint": "oxlint --max-warnings=0 --type-aware --type-check",
Copy link

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples lint script only runs oxlint, but the root package lint includes both oxfmt check and oxlint. This creates an inconsistency in linting behavior between root and examples. Consider adding oxfmt check to the examples lint script:

"lint": "oxfmt --no-error-on-unmatched-pattern --check . && oxlint --max-warnings=0 --type-aware --type-check"

Or if oxfmt is not needed in examples, document why the linting approach differs from the root package.

Suggested change
"lint": "oxlint --max-warnings=0 --type-aware --type-check",
"lint": "oxfmt --no-error-on-unmatched-pattern --check . && oxlint --max-warnings=0 --type-aware --type-check",

Copilot uses AI. Check for mistakes.
"format": "oxlint --max-warnings=0 --type-aware --type-check --fix"
},
"dependencies": {
"@stackone/ai": "workspace:*"
Expand Down
2 changes: 2 additions & 0 deletions knip.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ export default {
},
ignore: ['**/*.test.ts', '**/*.spec.ts', '**/*.test-d.ts'],
ignoreBinaries: ['only-allow'],
ignoreDependencies: ['@typescript/native-preview', 'lefthook'],
rules: {
optionalPeerDependencies: 'off',
devDependencies: 'warn',
},
} satisfies KnipConfig;
29 changes: 13 additions & 16 deletions lefthook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,16 @@
pre-commit:
parallel: true
piped: true
jobs:
- name: lint-fmt
group:
piped: true
jobs:
- name: oxlint
glob: '*.{ts,tsx,js,jsx,mts,cts}'
run: bun oxlint --max-warnings=0 --type-aware --fix {staged_files}
stage_fixed: true
- name: oxfmt
glob: '*'
run: bun oxfmt --no-error-on-unmatched-pattern {staged_files}
stage_fixed: true
- name: oxlint
glob: '*.{ts,tsx,js,jsx,mts,cts}'
run: bun oxlint --max-warnings=0 --type-aware --type-check --fix {staged_files}
stage_fixed: true
- name: oxfmt
glob: '*'
run: bun oxfmt --no-error-on-unmatched-pattern {staged_files}
stage_fixed: true

- name: typecheck
glob: '*.{ts,tsx,mts,cts}'
run: bun run typecheck
push:
jobs:
- name: knip
run: pnpm run lint:knip
13 changes: 6 additions & 7 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,18 @@
"build": "tsdown",
"format": "pnpm --no-bail --aggregate-output run '/^format:/'",
"format:oxfmt": "oxfmt --no-error-on-unmatched-pattern .",
"format:oxlint": "oxlint --max-warnings=0 --type-aware --fix",
"format:oxlint": "oxlint --max-warnings=0 --type-aware --type-check --fix",
"format:knip": "knip --fix --no-exit-code",
"lint": "pnpm --no-bail --aggregate-output run '/^lint:/'",
"format:submodule": "pnpm --parallel -r --aggregate-output format",
"lint": "pnpm --aggregate-output run '/^lint:/'",
"lint:oxfmt": "oxfmt --no-error-on-unmatched-pattern --check .",
"lint:oxlint": "oxlint --max-warnings=0 --type-aware",
"lint:oxlint": "oxlint --max-warnings=0 --type-aware --type-check",
"lint:submodule": "pnpm --parallel -r --aggregate-output lint",
"lint:knip": "knip",
"preinstall": "npx only-allow pnpm",
"prepack": "npm pkg delete scripts.preinstall && pnpm run build",
"test": "vitest",
"coverage": "vitest run --coverage",
"typecheck": "pnpm --aggregate-output run '/^typecheck:/'",
"typecheck:submodules": "pnpm --parallel -r --aggregate-output typecheck",
"typecheck:root": "tsgo --noEmit"
"coverage": "vitest run --coverage"
},
"dependencies": {
"@modelcontextprotocol/sdk": "catalog:prod",
Expand Down
Loading