docs(workflow): remove biome references from development workflow skill #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update lint and format command descriptions to reflect current tools (oxfmt, oxlint, knip) - Remove outdated Biome mentions
commit: |
There was a problem hiding this comment.
Pull request overview
This PR updates the development workflow documentation to remove outdated references to Biome and replace them with the current tooling stack (oxfmt, oxlint, knip).
- Removes Biome references from lint and format command descriptions
- Updates documentation to reflect current tooling configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - `pnpm lint` - Run Biome linter | ||
| - `pnpm format` - Format code with Biome | ||
| - `pnpm lint` - Run linter (oxfmt, oxlint, knip) | ||
| - `pnpm format` - Format code (oxfmt, oxlint, knip) |
There was a problem hiding this comment.
The description for pnpm format is misleading. Looking at package.json, this command runs format:oxfmt, format:oxlint, and format:knip. However:
oxfmtis the formatteroxlint --fixapplies auto-fixes for linting issuesknip --fixremoves unused code
The description should clarify that this command formats code and applies auto-fixes, not just "Format code (oxfmt, oxlint, knip)". Consider: - pnpm format - Format code with oxfmt and apply auto-fixes (oxlint, knip)
Suggested change
| - `pnpm format` - Format code (oxfmt, oxlint, knip) | |
| - `pnpm format` - Format code with oxfmt and apply auto-fixes (oxlint, knip) |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Summary by cubic
Removed outdated Biome references in the development workflow skill and updated lint/format command descriptions to reflect current tools (oxfmt, oxlint, knip). This keeps the docs accurate and aligned with our current toolchain.
Written for commit aaf0721. Summary will update automatically on new commits.