fix: remove unified API validation and support #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the unified API tool validation that was previously used to detect legacy/misconfigured accounts. This validation is no longer needed as the unified API architecture has been deprecated. Changes: - Remove UNIFIED_API_PREFIX constant from consts.ts - Remove validateToolName() method from StackOneToolSet class - Remove unified API tool validation call in fetchTools() - Remove UNIFIED_API_PREFIX import from toolsets.ts - Remove @see reference to unified-cloud-api in schema.ts - Remove corresponding unit test for unified API tool detection This simplifies the codebase by removing code paths that are no longer relevant to the current API architecture.
ryoppippi
changed the title
commit: |
There was a problem hiding this comment.
Pull request overview
This PR removes deprecated unified API validation code that was used to detect and reject legacy/misconfigured accounts. The unified API architecture has been deprecated, making this validation obsolete.
Key Changes:
- Removed unified API tool name validation logic from
StackOneToolSetclass - Removed
UNIFIED_API_PREFIXconstant definition - Removed test coverage for unified API tool detection
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/consts.ts |
Removed UNIFIED_API_PREFIX constant definition |
src/toolsets.ts |
Removed UNIFIED_API_PREFIX import, validateToolName() method, and its call in fetchToolsFromMcp() |
src/toolsets.test.ts |
Removed test case for unified API tool validation error |
src/schema.ts |
Removed @see reference to deprecated unified-cloud-api service |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the unified API tool validation that was previously used to detect legacy/misconfigured accounts. This validation is no longer needed as the unified API architecture has been deprecated.
What Changed
UNIFIED_API_PREFIXconstant fromconsts.tsvalidateToolName()method fromStackOneToolSetclassfetchTools()@seereference to unified-cloud-api inschema.tsWhy
The unified API architecture has been deprecated, so the validation code that detected and rejected unified API tools is no longer necessary. This simplifies the codebase by removing obsolete code paths.
Summary by cubic
Removed unified API tool validation and references now that the architecture is deprecated. This simplifies tool fetching and avoids throwing configuration errors for unified_-prefixed tools.
Written for commit 18ca8b6. Summary will update automatically on new commits.