test: add error handling and edge case tests, improve coverage 85%→93% #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split StackOneError into error-stackone.ts - Split StackOneAPIError into error-stackone-api.ts - Remove re-export file errors.ts - Update all imports to use direct paths Improves searchability and code organisation.
- Add comprehensive tests for StackOneError and StackOneAPIError - Add tests for BaseTool RPC/local config and error handling - Add tests for StackOneToolSet dryRun mode and parameter extraction - Exclude type-only files from coverage (index.ts, type.ts) Coverage improvements: - Statements: 85.29% → 92.50% - Branch: 70.61% → 84.05% - Lines: 85.95% → 93.51%
ryoppippi
changed the title
commit: |
ryoppippi
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
ryoppippi
changed the title
There was a problem hiding this comment.
Pull request overview
This PR improves test coverage from 85% to 93% and refactors error classes into separate files for better code organization and maintainability.
- Splits error classes into dedicated files (
error-stackone.tsanderror-stackone-api.ts) - Adds comprehensive test coverage for error classes and tool execution paths
- Excludes type-only files from coverage metrics to focus on executable code
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vitest.config.ts | Excludes type-only files (index.ts, type.ts) from coverage calculation |
| src/utils/error-stackone.ts | New file containing base StackOneError class |
| src/utils/error-stackone-api.ts | Refactored to import StackOneError from separate file instead of defining it locally |
| src/utils/error-stackone.test.ts | New comprehensive tests for StackOneError class |
| src/utils/error-stackone-api.test.ts | New comprehensive tests for StackOneAPIError class including toString formatting |
| src/toolsets.test.ts | Added tests for dryRun mode, parameter extraction, and error handling |
| src/tool.test.ts | Added tests for RPC/local config metadata, execution options, and error handling |
| src/utils/try-import.ts | Updated import path from ./errors to ./error-stackone |
| src/utils/try-import.test.ts | Updated import path from ./errors to ./error-stackone |
| src/toolsets.ts | Updated import path from ./utils/errors to ./utils/error-stackone |
| src/tool.ts | Updated import path from ./utils/errors to ./utils/error-stackone |
| src/rpc-client.ts | Updated import path from ./utils/errors to ./utils/error-stackone-api |
| src/rpc-client.test.ts | Updated import path from ./utils/errors to ./utils/error-stackone-api |
| src/requestBuilder.ts | Updated import path from ./utils/errors to ./utils/error-stackone-api |
| src/requestBuilder.test.ts | Updated import path from ./utils/errors to ./utils/error-stackone-api |
| src/index.ts | Updated exports to import from new separate error files |
| src/feedback.ts | Updated import path from ./utils/errors to ./utils/error-stackone |
| src/feedback.test.ts | Updated import path from ./utils/errors to ./utils/error-stackone |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
glebedel
reviewed
Dec 22, 2025
src/utils/error-stackone-api.test.ts
Outdated
|
|
||
| it('should include endpoint URL when present in message', () => { | ||
| const error = new StackOneAPIError( | ||
| 'Request failed for https://api.stackone.com/unified/hris/employees', |
Contributor
There was a problem hiding this comment.
I don't think we should have unified endpoints related tests
Member
Author
There was a problem hiding this comment.
oh yes you are absolutely right!
Member
Author
Apply review feedback from @glebedel - this SDK should not have unified endpoints related tests. Changed the test URL from /unified/hris/employees to /tools/execute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves test coverage from 85% to 93% and refactors error classes into separate files for better code organisation and searchability.
What Changed
Refactoring:
errors.tsintoerror-stackone.tsanderror-stackone-api.tsTest Coverage:
StackOneErrorandStackOneAPIErrorBaseToolRPC/local config and error handlingStackOneToolSetdryRun mode and parameter extractionindex.ts,type.ts)Coverage Improvements
Testing
All 427 tests pass across 32 test files.
Summary by cubic
Boosts test coverage to ~93% and splits error classes into dedicated files for clearer imports and easier search.
Refactors
Test Coverage
Written for commit 9b56837. Summary will update automatically on new commits.