Skip to content

chore(lefthook): add lockfile integrity and dependency change checks #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryoppippi merged 2 commits into from
Jan 5, 2026
Merged

chore(lefthook): add lockfile integrity and dependency change checks #277

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8fd5f8
chore(lefthook): add lockfile integrity and dependency change checks
ryoppippi Jan 5, 2026
d65855f
fix(lefthook): match all package.json files in monorepo
ryoppippi Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lefthook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,12 @@ pre-push:
jobs:
- name: knip
run: pnpm run lint:knip
- name: lockfile-sync-check
glob: '{**/package.json,pnpm-workspace.yaml}'
run: pnpm install --lockfile-only --frozen-lockfile
Copy link

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The combination of --lockfile-only and --frozen-lockfile flags is contradictory. The --lockfile-only flag tells pnpm to update the lockfile, while --frozen-lockfile requires that the lockfile must not be modified. This command will fail.

For verifying that package.json/pnpm-workspace.yaml changes are reflected in pnpm-lock.yaml, you should use only --frozen-lockfile (which will fail if the lockfile is out of sync) or consider using pnpm install --frozen-lockfile --dry-run to verify without making changes.

Suggested change
run: pnpm install --lockfile-only --frozen-lockfile
run: pnpm install --frozen-lockfile --dry-run

Copilot uses AI. Check for mistakes.
- name: lint-all-on-lockfile-change
glob: 'pnpm-lock.yaml'
run: pnpm lint
- name: test-all-on-lockfile-change
glob: 'pnpm-lock.yaml'
run: pnpm test
Loading