chore(nix): remove flake-parts dependency #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify flake.nix by removing flake-parts and using standard nixpkgs.lib.genAttrs pattern instead. The devShell configuration is simple enough that flake-parts adds unnecessary complexity. - Remove flake-parts input - Use forAllSystems helper with genAttrs - Maintain identical functionality
commit: |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR simplifies the Nix flake configuration by removing the flake-parts dependency and replacing it with the standard nixpkgs.lib.genAttrs pattern for multi-system support.
- Removed flake-parts and nixpkgs-lib dependencies
- Implemented standard Nix pattern using
forAllSystemshelper withgenAttrs - Maintained identical devShell functionality with all buildInputs preserved
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| flake.nix | Refactored to use standard multi-system pattern, removing flake-parts dependency while preserving devShell configuration |
| flake.lock | Removed flake-parts and nixpkgs-lib entries, keeping only nixpkgs dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| systems = [ | ||
| "x86_64-linux" | ||
| "aarch64-linux" | ||
| "aarch64-darwin" |
There was a problem hiding this comment.
The systems list is missing "x86_64-darwin" (Intel macOS). This system is commonly supported in Nix flakes alongside the three systems listed here. Consider adding it to maintain broader compatibility, especially if users on Intel Macs need to use this development shell.
Suggested change
| "aarch64-darwin" | |
| "aarch64-darwin" | |
| "x86_64-darwin" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nixpkgs.lib.genAttrspattern for multi-system supportRationale
The devShell configuration is simple enough that flake-parts adds unnecessary complexity. Using the standard Nix pattern reduces dependencies without losing any functionality.
Test plan
nix developand verify the shell works correctlySummary by cubic
Removed flake-parts and switched to nixpkgs.lib.genAttrs to generate devShells across systems. Functionality stays the same, with a simpler flake.
Refactors
Dependencies
Written for commit 1f0f1b3. Summary will update on new commits.