Skip to content

Conversation

@ryoppippi
Copy link
Member

@ryoppippi ryoppippi commented Jan 16, 2026

Reverts #298


Summary by cubic

Reverts the previous switch to nix-quick-install-action in CI to restore the prior Nix install flow.

  • Dependencies
    • Use cachix/[email protected] in setup-nix.
    • Pass github_access_token: ${{ github.token }} for authenticated installs.

Written for commit 203a571. Summary will update on new commits.

Copilot AI review requested due to automatic review settings January 16, 2026 21:31
@ryoppippi ryoppippi requested a review from a team as a code owner January 16, 2026 21:31
@ryoppippi ryoppippi merged commit 66ca9ef into main Jan 16, 2026
17 of 18 checks passed
@ryoppippi ryoppippi deleted the revert-298-perf/nix-quick-install-action branch January 16, 2026 21:31
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts a previous change that switched from cachix/install-nix-action to nixbuild/nix-quick-install-action for CI performance improvements. The revert restores the use of the Cachix action along with the github_access_token parameter.

Changes:

  • Revert Nix installation action from nixbuild/nix-quick-install-action back to cachix/[email protected]
  • Re-add github_access_token parameter to the action configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

uses: nixbuild/nix-quick-install-action@2c9db80fb984ceb1bcaa77cdda3fdf8cfba92035 # v34
uses: cachix/install-nix-action@4e002c8ec80594ecd40e759629461e26c8abed15 # v31.9.0
with:
github_access_token: ${{ github.token }}
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action expects inputs.github_token (an input parameter passed to this composite action), but the code uses github.token which is only available in workflow context, not in composite actions. This should be changed to accept a token input parameter and pass it through, or the line should use a different approach to access the token if composite actions support it in this version.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants