chore: remove obsolete pull_oas.py script #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script was used to download OpenAPI specifications from docs.stackone.com and save them locally for OAS-based tool generation. Since the OAS-based getTools implementation was removed in d50d5fb (refactor!: remove deprecated OAS-based getTools, migrate to fetchTools only), this script is no longer needed. The SDK now exclusively uses fetchTools to retrieve tool definitions directly from the API at runtime.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the obsolete scripts/pull_oas.py script that was previously used to download OpenAPI specifications from docs.stackone.com for local tool generation. The script became obsolete after PR #42 migrated to fetching tools dynamically via the MCP (Model Context Protocol) instead of using locally stored OAS files.
Key Changes:
- Removes the entire
scripts/pull_oas.pyfile (89 lines) - Eliminates dependencies on httpx, pyyaml, requests, and beautifulsoup4 for this script
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
scripts/pull_oas.pyscript which is no longer neededThis script was used to download OpenAPI specifications from docs.stackone.com for local OAS-based tool generation. Since #42 removed the OAS-based
getToolsimplementation and migrated tofetchToolsonly, this script serves no purpose.Test plan
pull_oas.pySummary by cubic
Removed scripts/pull_oas.py, which downloaded OpenAPI specs for OAS-based tool generation. We now use fetchTools at runtime, so local OAS pulling is not needed.
Written for commit 1c15330. Summary will update automatically on new commits.