Skip to content

fix(ci): use just commands in CI and release workflows #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryoppippi merged 3 commits into from
Dec 18, 2025
+21 −14
Merged

fix(ci): use just commands in CI and release workflows #57

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8b4bc5
chore(ci): use just commands instead of direct uv/mypy calls
ryoppippi Dec 18, 2025
a8cf7f3
chore(ci): use just commands in release workflow
ryoppippi Dec 18, 2025
75a0462
Merge remote-tracking branch 'origin/main' into chore/ci-use-just-com…
ryoppippi Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,18 +37,13 @@ jobs:
uses: ./.github/actions/setup-nix

- name: Install dependencies
run: nix develop --command uv sync ${{ matrix.sync-extras }}
run: nix develop --command just install ${{ matrix.sync-extras }}

- name: Run Lint
run: nix develop --command uv run ruff check .
run: nix develop --command just lint

- name: Run Mypy
run: |
if [[ "${{ matrix.python-version }}" == "3.9" ]]; then
nix develop --command uv run mypy stackone_ai --exclude stackone_ai/server.py
else
nix develop --command uv run mypy stackone_ai
fi
run: nix develop --command just mypy

- name: Run Tests
run: nix develop --command uv run pytest
run: nix develop --command just test
4 changes: 2 additions & 2 deletions justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Install dependencies and pre-commit hooks
install:
uv sync --all-extras
install *extras:
Copy link

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The install command now requires explicit arguments, which breaks backwards compatibility. When called without arguments (e.g., just install), it will run uv sync with no extras, whereas previously it would install all extras.

Consider providing a default value to maintain backwards compatibility:

install extras="--all-extras":
	uv sync {{ extras }}

This allows the CI to override with different extras while maintaining sensible defaults for local development.

Suggested change
install *extras:
install extras="--all-extras":

Copilot uses AI. Check for mistakes.
Copy link

@cubic-dev-ai cubic-dev-ai bot Dec 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Default behavior change: just install without arguments no longer installs all extras. Previously it ran uv sync --all-extras, now it runs uv sync with no extras. Consider preserving the old default behavior with:

install *extras='--all-extras':

Or document that developers must now explicitly run just install --all-extras.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At justfile, line 2:

<comment>Default behavior change: `just install` without arguments no longer installs all extras. Previously it ran `uv sync --all-extras`, now it runs `uv sync` with no extras. Consider preserving the old default behavior with:

install *extras='--all-extras':

Or document that developers must now explicitly run `just install --all-extras`.</comment>

<file context>
@@ -1,6 +1,6 @@
 # Install dependencies and pre-commit hooks
-install:
-	uv sync --all-extras
+install *extras:
+	uv sync {{ extras }}
 
</file context>
Suggested change
install *extras:
install *extras='--all-extras':
Fix with Cubic

uv sync {{ extras }}

# Run ruff linting
lint:
Expand Down
Loading