Skip to content

chore(gitleaks): update allowlist to ignore venv #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryoppippi merged 3 commits into from
Dec 23, 2025
Merged

chore(gitleaks): update allowlist to ignore venv #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15b2870
chore(gitleaks): only uv.lock
ryoppippi Dec 22, 2025
23a6968
chore(gitignore): remove docs/site
ryoppippi Dec 22, 2025
c5acf4c
chore(gitleaks): ignore venv
ryoppippi Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ coverage/

.DS_Store

# Documentation build
.docs/
site/

*.egg-info
dist/
Expand Down
5 changes: 3 additions & 2 deletions .gitleaks.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ useDefault = true
[allowlist]
description = "Global allowlist"
paths = [
'''\.lock$''',
'''\.snap$''',
'''uv\.lock$''',
'''venv/''',
Copy link

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .gitignore file already contains .venv (line 3), which will only ignore that specific directory name at the repository root. However, the gitleaks allowlist pattern \.venv/ uses a regex that will match .venv/ anywhere in the path. Additionally, venv/ in the gitleaks allowlist will match venv/ directories but there's no corresponding entry in .gitignore to prevent these directories from being committed. Consider adding venv/ to .gitignore to maintain consistency between what gitleaks ignores and what git ignores.

Suggested change
'''venv/''',

Copilot uses AI. Check for mistakes.
'''\.venv/''',
'''\.ruff_cache/''',
]
Comment on lines +13 to 14
Copy link

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .ruff_cache/ directory added to the gitleaks allowlist should also be present in .gitignore to prevent it from being committed to the repository. This cache directory is generated by the Ruff linter and typically should not be tracked by git. Consider adding .ruff_cache/ to .gitignore for consistency.

Suggested change
'''\.ruff_cache/''',
]
]

Copilot uses AI. Check for mistakes.