refactor(models): remove unused _arun method from LangChain tool #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _arun async method was just wrapping the sync _run method without providing any actual async benefits. LangChain's BaseTool provides a default implementation that raises NotImplementedError, which is sufficient for our use case since we don't support true async execution.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the StackOneLangChainTool class by removing the unused _arun async method, which was merely wrapping the synchronous _run method without providing actual asynchronous benefits.
- Removes the
_arunmethod from theStackOneLangChainToolinner class - Relies on LangChain's
BaseTooldefault implementation which raisesNotImplementedError - Cleans up code by eliminating misleading async functionality
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_arunasync method fromStackOneLangChainTool_runwithout actual async benefitsBaseToolprovides a defaultNotImplementedErrorimplementationTest plan
Summary by cubic
Removed the unused
_arunmethod fromStackOneLangChainTool. We now rely onBaseTool’s defaultNotImplementedErrorfor async since the tool doesn’t support true async execution.Written for commit bc08246. Summary will update automatically on new commits.