Skip to content

chore: basepyright -> ty #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryoppippi merged 1 commit into from
Jan 6, 2026
Merged

chore: basepyright -> ty #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
ty = {
enable = true;
name = "ty";
entry = "${pkgs.uv}/bin/uv run ty check";
entry = "${pkgs.ty}/bin/ty check";
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pre-commit hook entry for ty is missing the target directory argument. The justfile's ty target (line 31) runs uv run ty check stackone_ai, but this hook runs ty check without specifying the directory to check. This inconsistency may cause the hook to check different files than intended or fail to locate the files to check.

Suggested change
entry = "${pkgs.ty}/bin/ty check";
entry = "${pkgs.ty}/bin/ty check stackone_ai";

Copilot uses AI. Check for mistakes.
files = "^stackone_ai/";
language = "system";
types = [ "python" ];
Expand All @@ -92,9 +92,9 @@
devShells.default = pkgs.mkShell {
buildInputs = with pkgs; [
uv
ty
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title says "basepyright -> ty" but the actual package being removed is "basedpyright" (note the 'd'). While this is just a title issue and doesn't affect the code, it creates confusion about what's being replaced.

Copilot uses AI. Check for mistakes.
just
nixfmt-rfc-style
basedpyright

# security
gitleaks
Expand Down