Skip to content

Modernize and refactor stackstorm.js #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blag merged 5 commits into from
Jul 22, 2019
Merged

Modernize and refactor stackstorm.js #187

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
500d779
[skip ci] Rename src/stackstorm.js to src/stackstorm_api.js
blag Jul 19, 2019
50e9e32
[skip ci] Refactor stackstorm_api.js to use JS (old) classes
blag Jul 19, 2019
032ea82
Update tests to account for refactored stackstorm_api.js
blag Jul 19, 2019
2c4ceed
[skip ci] Add a line to the changelog
blag Jul 19, 2019
020daf3
Revert changes to stop() semantics
blag Jul 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ in development
* Small refactor and more tests (for ``scripts/stackstorm.js``) (improvement)
* Refactor chat providers into their own modules (improvement)
* Modernize directory structure to be more consistent with other hubot plugins (improvement)
* Split out the functionality of ``src/stackstorm.js`` into ``stackstorm_api.js`` and refactor it be a JS old style class with a wrapper (improvement)

0.9.6
-----
Expand Down
Loading