-
-
Notifications
You must be signed in to change notification settings - Fork 779
Bump eventlet from 0.30.2 to 0.31.0 #5257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
690cef7 to
e7b729f
Compare
e7b729f to
f34257a
Compare
Bumps [eventlet](https://github.com/eventlet/eventlet) from 0.30.2 to 0.31.0. - [Release notes](https://github.com/eventlet/eventlet/releases) - [Changelog](https://github.com/eventlet/eventlet/blob/master/NEWS) - [Commits](eventlet/eventlet@v0.30.2...v0.31.0) Signed-off-by: dependabot[bot] <[email protected]>
f34257a to
c2a6f6f
Compare
|
Based on history, we tried to update the However, because of the breaking change, it fails the build in
Per eventlet/eventlet#702 (comment), the proper fix in So the current status is that we're waiting for the |
|
Update on gunicorn 7 days ago, saying new release would be out this week: benoitc/gunicorn#2638 |
|
Looks like benoitc/gunicorn#2638 is still unreleased. |
|
@armab Shall we move this to 3.7.0? |
|
Yeah. 1 week has become 1 month, and they have only merged 1 PR in that time. That PR has nothing to do with the release (afaict), so who knows when it will happen. I moved this to 3.7.0 |
|
No new release - latest is still 20.1.0 - but project still active. 6 open issues in the next release plan - https://github.com/benoitc/gunicorn/milestone/20. |
|
Thanks for checking! |
|
More than 1 year later and still no gunicorn 21 release. Eventlet is now at 0.33.0 which makes this PR obsolete. |
|
What are peoples opinion on the idea of forking gunicorn and building v3.8 from our forked repo that includes that patch we need to move past eventlet 0.30.2? |
|
I think it is on their master branch, so let's try targeting a git commit and avoid actually forking it. They keep saying something about some CI infrastructure change, but they have not expounded. And there's no movement on releasing. So I don't see what else we can do. |
|
OK, we'll start without forking and see if we encounter other issues related to gunicron that require us to accumulate patches in a forked repo. |
ba47e50 to
bdc6e5e
Compare
cognifloyd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to use PEP 440 style requirements instead of the legacy pop format (the #egg= format) because pants does not support the legacy pip format.
See #5673 where I changed all the other git requirements to PEP 440 urls.
|
gunicorn 21 was released in July |
|
#6061 bumped eventlet to |
|
Thanks @jk464 for bumping this thread. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps eventlet from 0.30.2 to 0.31.0.
Changelog
Sourced from eventlet's changelog.
Commits
f717f38v0.31.0 release1412f5ewebsocket: Limit maximum uncompressed frame length to 8MiBb0be94ev0.30.3 releasedf0bc00wsgi: websocket ALREADY_HANDLED flag on corolocal377b4fbgreen.ssl: Set suppress_ragged_eofs default based on SSLSocket defaults71b76bfSecurity Policy50441fcgreenio: socket.connect_ex returned None instead of 0 on successe16fcabUse _imp instead of deprecated impYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.