Update sensor wrapper to make list_values() method congruent with regular datastore method.
#5913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egular datastore method. Specifically, support use of `limit` and `offset` parameters.
pull-request-size
bot
added
the
size/XS
arm4b
suggested changes
Feb 25, 2023
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
Thanks for the PR. The change makes sense 👍
Needs updating the tests per
TypeError: list_values() got an unexpected keyword argument 'limit'
https://github.com/StackStorm/st2/actions/runs/4265952599/jobs/7425903007#step:15:1228
Contributor
|
this was implemented in #6218 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, support use of
limitandoffsetparameters.