st2test Popen.pid bugfix #6184
Merged
st2test Popen.pid bugfix #6184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can tell, Popen has never had an 'id' attribute. It has 'pid'. I checked both cpython and eventlet sources.
pull-request-size
bot
added
the
size/XS
nzlosh
approved these changes
Apr 19, 2024
amanda11
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix reference to non-existent Popen.id attribute.
It seems we don't run this code path in st2tests very often. I only see this when I'm debugging unrelated errors.
I searched through st2 git history for more context without success. I can't find the Popen.id attribute in several versions of cpython, nor in eventlet/greenlet.
So, this replaces
Popen.idwithPopen.pid.This was extracted from #6130.