Skip to content

Conversation

@cognifloyd
Copy link
Member

@cognifloyd cognifloyd commented Apr 19, 2024

This is primarily work by @nzlosh who figured out how to replace screen with tmux in #6157. On top of that, I:

  • reverted a port change in launchdev.sh that looks like copy pasta,
  • added a sleep to avoid polluting so many logs with "mongo document already exists" errors as st2 processes started nearly in parallel and then attempt to initialize the database in parallel,
  • refactored a few messages in launchdev.sh,
  • finished cleaning up some other files to finish removing screen, and
  • adjusted logs capture in GitHub Actions to be more reliable and to prevent one test from overwriting the logs of other tests.

Some of my changes were extracted from #6130.

@cognifloyd cognifloyd added this to the 3.9.0 milestone Apr 19, 2024
@cognifloyd cognifloyd self-assigned this Apr 19, 2024
@cognifloyd cognifloyd requested review from a team, amanda11, nzlosh and winem April 19, 2024 06:38
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines. Requires some effort to review. label Apr 19, 2024
@cognifloyd cognifloyd requested a review from a team April 19, 2024 08:14
@cognifloyd cognifloyd requested a review from mamercad April 19, 2024 17:03
@cognifloyd cognifloyd enabled auto-merge April 22, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure: ci/cd refactor size/L PR that changes 100-499 lines. Requires some effort to review. tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants