Skip to content

Drop unittest2 #6187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cognifloyd merged 9 commits into from
Apr 22, 2024
Merged

Drop unittest2 #6187

cognifloyd merged 9 commits into from
Apr 22, 2024

Conversation

@cognifloyd
Copy link
Member

@cognifloyd cognifloyd commented Apr 19, 2024 •
edited
Loading

This PR cherry-picks work by @nzlosh from #6157

  • Remove unittest2
  • Fix for DeprecationWarning: Please use assertRaisesRegex
  • Fix DeprecationWarning: Please use assertRegex instead.
  • Fix for DeprecationWarning: Please use assertNotEqual instead.
  • add changelog entry
  • Replace deprecated self.assertItemsEqual with assert.

@cognifloyd cognifloyd added this to the 3.9.0 milestone Apr 19, 2024
@cognifloyd cognifloyd requested review from a team, amanda11, guzzijones, mamercad, nzlosh and winem April 19, 2024 08:11
@pull-request-size pull-request-size bot added the size/XL PR that changes 500-999 lines. Consider splitting work into several ones that easier to review. label Apr 19, 2024
@cognifloyd cognifloyd mentioned this pull request Apr 19, 2024
Closed
@cognifloyd cognifloyd requested a review from a team April 19, 2024 08:15
@cognifloyd
remove unittest2 from lockfiles/st2.lock
d37e2f6 
Lockfile diff: lockfiles/st2.lock [st2]

==                    Upgraded dependencies                     ==

  argcomplete                    3.2.3        -->   3.3.0
  exceptiongroup                 1.2.0        -->   1.2.1
  gunicorn                       21.2.0       -->   22.0.0
  idna                           3.6          -->   3.7
  itsdangerous                   2.1.2        -->   2.2.0
  kombu                          5.3.6        -->   5.3.7
  orjson                         3.10.0       -->   3.10.1
  setuptools                     69.2.0       -->   69.5.1
  virtualenv                     20.25.1      -->   20.25.3

==                     Removed dependencies                     ==

  linecache2                     1.0.0
  traceback2                     1.4.0
  unittest2                      1.1.0
@pull-request-size pull-request-size bot added size/XXL PR that changes 1000+ lines. You should absolutely split your PR into several. and removed size/XL PR that changes 500-999 lines. Consider splitting work into several ones that easier to review. labels Apr 19, 2024
@cognifloyd
Copy link
Member Author

cognifloyd commented Apr 19, 2024

It would probably be easiest to review each commit in order.

@cognifloyd cognifloyd merged commit 5865d12 into master Apr 22, 2024
@cognifloyd cognifloyd deleted the drop-unittest2 branch April 22, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nzlosh nzlosh nzlosh approved these changes

@amanda11 amanda11 amanda11 approved these changes

@guzzijones guzzijones Awaiting requested review from guzzijones

@mamercad mamercad Awaiting requested review from mamercad

@winem winem Awaiting requested review from winem

Assignees

@nzlosh nzlosh

Labels

external dependency size/XXL PR that changes 1000+ lines. You should absolutely split your PR into several. tests

Projects

None yet

Milestone

3.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cognifloyd @nzlosh @amanda11