Skip to content

Fix deprecated use of logging.warn #6190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cognifloyd wants to merge 7 commits into from
Closed

Fix deprecated use of logging.warn #6190

cognifloyd wants to merge 7 commits into from

Conversation

@cognifloyd
Copy link
Member

@cognifloyd cognifloyd commented Apr 25, 2024 •
edited
Loading

  • Fix DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
  • Fixed more DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
  • Replace 'warn' with 'warning' method
  • Skip test_warn_on_bad_config_permissions when run as root user.
  • Skip test_get_cached_auth_token_invalid_permissions if run as root
  • Skip test_cache_auth_token_invalid_permissions if run as root

@cognifloyd cognifloyd added this to the 3.9.0 milestone Apr 25, 2024
@cognifloyd cognifloyd requested review from a team, amanda11, mamercad, nzlosh and winem April 25, 2024 18:42
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines. Good size to review. label Apr 25, 2024
@cognifloyd cognifloyd force-pushed the fix_deprecation_warnings_logging branch from 10a439f to f466f73 Compare April 25, 2024 18:44
@cognifloyd cognifloyd force-pushed the fix_deprecation_warnings_logging branch from f466f73 to c699158 Compare April 25, 2024 22:06
@cognifloyd
Copy link
Member Author

cognifloyd commented Apr 25, 2024

Merged into #6188 now that I found the missing commit.

@cognifloyd cognifloyd closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amanda11 amanda11 Awaiting requested review from amanda11

@mamercad mamercad Awaiting requested review from mamercad

@nzlosh nzlosh Awaiting requested review from nzlosh

@winem winem Awaiting requested review from winem

Assignees

@cognifloyd cognifloyd

@nzlosh nzlosh

Labels

logging maintenance refactor size/M PR that changes 30-99 lines. Good size to review.

Projects

None yet

Milestone

3.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@cognifloyd @nzlosh