Update oslo.config to prepare for python 3.10 support.
#6193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
cognifloyd
commented
Apr 27, 2024
|
|
||
| apscheduler | ||
| argcomplete | ||
| argparse |
Member
Author
There was a problem hiding this comment.
This was only included as a transitive dep of the old version of oslo.config, and the newer versions don't require it, so pants happily removed it from the lockfile. However, our code directly imports it, so I added it back as a direct dep.
Contributor
There was a problem hiding this comment.
Thanks for the hint. Was already wondering how it could work without argparse.
cognifloyd
commented
Apr 27, 2024
|
|
||
| expected_msg = "Valid values are: strict, lax, none, unset" | ||
| self.assertRaisesRegex( | ||
| ValueError, expected_msg, validate_auth_cookie_is_correctly_configured |
Member
Author
There was a problem hiding this comment.
The newer version of oslo.config errors out itself, so some of our custom validation in the validate_auth_cookie_is_correctly_configured function is no longer needed.
cognifloyd
commented
Apr 27, 2024
nzlosh
approved these changes
Apr 30, 2024
Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == filelock 3.13.4 --> 3.14.0 oslo-config 1.12.1 --> 9.4.0 pytest 8.1.1 --> 8.2.0 virtualenv 20.26.0 --> 20.26.1 == Added dependencies == rfc3986 2.0.0
cognifloyd
force-pushed
the
update-oslo.config
branch
from
7a6d0cb to
efb75de
Compare
Member
Author
|
rebased on master |
winem
approved these changes
May 8, 2024
|
|
||
| apscheduler | ||
| argcomplete | ||
| argparse |
Contributor
There was a problem hiding this comment.
Thanks for the hint. Was already wondering how it could work without argparse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts the
oslo.configcommits by @nzlosh from #6157.Lockfile diff: