Fix packs.get action
#6226
Merged
Fix packs.get action
#6226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses StackStorm#6225. This should allow users to specify a branch when using the `packs.get` command. This addresses the assumption in the code that the primary branch of a git repository corresponding to an action is `master`. * Add `branch` parameter to `get.yaml`. Default to `master` to maintain current functionality/expectations. * Update `run` in `pack_mgmt.get_install.py`. Now accepts `branch` param and uses an `fstring` to represent the in `git rev list`.
pull-request-size
bot
added
the
size/S
Contributor
Author
|
I can add tests here, if that is required. There are, however, not any existing tests for this action, so I thought it might not be. Fundamentally, the change here is very small and the action is very simple. Whomever reviews this, let me know if new tests are required. |
nzlosh
approved these changes
Jul 26, 2024
Contributor
nzlosh
left a comment
nzlosh
left a comment
There was a problem hiding this comment.
This change looks good to me. Thank you for the contribution.
amanda11
approved these changes
Jul 26, 2024
Ein-nor
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6225. This should allow users to specify a branch when using the
packs.getcommand. This addresses the assumption in the code that the primary branch of a git repository corresponding to an action ismaster.branchparameter toget.yaml. Default tomasterto maintain current functionality/expectations.runinpack_mgmt.get_install.py. Now acceptsbranchparam and uses anfstringto represent the ingit rev list.