Update pytest-cov version requirement and fix other build failures#6363
Merged
nzlosh merged 7 commits intoStackStorm:masterfrom Dec 10, 2025
Merged
Update pytest-cov version requirement and fix other build failures#6363nzlosh merged 7 commits intoStackStorm:masterfrom
nzlosh merged 7 commits intoStackStorm:masterfrom
Conversation
While Stackstorm supports python 3.8 (rocky8), pytest-cov needs to be downgraded to 5.0.0
Contributor
|
I've re-run the tests that failed and they're all passing. Thank you for fixing this. 👍 |
nzlosh
approved these changes
Dec 10, 2025
rush-skills
approved these changes
Dec 10, 2025
nzlosh
pushed a commit
that referenced
this pull request
Dec 10, 2025
…6363) * Update pytest-cov version requirement While Stackstorm supports python 3.8 (rocky8), pytest-cov needs to be downgraded to 5.0.0 * Update changelog * Pin DOCKER_API_VERSION * Pin pynacl, newer versions cause build conflicts * Undo local compatability changes * Note in changelog about pinning the DOCKER_API_VERSION * Regen pants lockfile
cognifloyd
reviewed
Dec 16, 2025
| '>7' | ||
| '>=4.0.3' | ||
| '>=6.1.1' | ||
| '>=5.0.0' |
Member
There was a problem hiding this comment.
I wonder if the GHA workflow to regenerate the lockfile should learn to deal with this file somehow.
This file is not a simple "copy the locked version", so we'd need to be careful to not turn that workflow into a maintenance headache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1# pytest-cov fix
While Stackstorm supports python 3.8 (rocky8), pytest-cov needs to be downgraded to 5.0.0. This was updated in #6340
Fresh 3.9 install on Rocky8
2# pin DOCKER_API_VERSION
According to https://circleci.com/docs/guides/execution-managed/building-docker-images/ circleci currently supports up to
docker24however installing the latest docker-cli uses an API version that docker24 does not support. Thus we can pin it to1.43which is the maximum API version allowed with docker243# pin pynacl
The newest version of pynacl (pulled in by paramiko) requires a newer version of cffi than we pin, so pin pynacl at 1.6.0