Skip to content

Fix static analysis issues #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix static analysis issues #25

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
729c130
Replace double quotes with single quote
meysammahfouzi Apr 9, 2024
1dd59ba
Add Library directive
meysammahfouzi Apr 9, 2024
bc4c396
Merge branch 'main' into fix_static_analysis_issues
meysammahfouzi Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/src/generators/logging/logger_class_content.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ const String loggerClassPrefex = '''
/// Maybe this should be generated for the user as well?
///
/// import 'package:customer_app/services/stackdriver/stackdriver_service.dart';
library;

import 'package:flutter/foundation.dart';
import 'package:logger/logger.dart';
''';
Expand Down Expand Up @@ -73,7 +75,7 @@ class SimpleLogPrinter extends LogPrinter {
.last;
} else {
final realFirstLine = formattedStacktrace
?.firstWhere((line) => line.contains(className), orElse: () => "");
?.firstWhere((line) => line.contains(className), orElse: () => '');

final methodName = realFirstLine?.replaceAll('\$className.', '');
return methodName;
Expand Down Expand Up @@ -122,7 +124,7 @@ List<String>? _formatStackTrace(StackTrace stackTrace, int methodCount) {
if (match.group(2)!.startsWith('package:logger')) {
continue;
}
var newLine = ("\${match.group(1)}");
var newLine = ('\${match.group(1)}');
formatted.add(newLine.replaceAll('<anonymous closure>', '()'));
if (++count == methodCount) {
break;
Expand Down