Skip to content

Generate proper route names when using custom names #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Generate proper route names when using custom names #29

wants to merge 3 commits into from

Conversation

kkalisz
Copy link

@kkalisz kkalisz commented Jul 8, 2024 •
edited
Loading

Issue:
When MaterialRoute is created with custom name, generator ignores custom name and create Route based on raw page value

before

        MaterialRoute(page: WorkoutListView, path: 'workout', name: 'workoutListHome'),
        MaterialRoute(page: RoutineListView, path: 'routine', name: 'routineListHome'),

err2

after fix

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kkalisz