Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates configuration settings for the MCP server transport mode. The changes include updating the endpoint path to use a trailing slash, renaming the transport mode constant from "http-stream" to "streamable-http" in both code and documentation, and adjusting the error messaging accordingly.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/mcp/server.go | Updated the endpoint path to include a trailing slash. |
| cmd/server/main.go | Changed transport mode constant and corresponding error message. |
| README.md | Revised documentation to reflect the updated transport mode. |
Comments suppressed due to low confidence (4)
pkg/mcp/server.go:167
- The endpoint path now includes a trailing slash, which may change route matching behavior. Please confirm that this change is intentional and consistent with the server's routing requirements.
server.WithEndpointPath("/mcp/"),
cmd/server/main.go:25
- The transport mode constant has been updated to 'streamable-http'. Ensure that all parts of the system consuming this constant are updated to avoid inconsistencies.
TransportHTTPStream TransportMode = "streamable-http"
cmd/server/main.go:38
- The error message now reflects the updated allowed values. Verify that this update aligns with all relevant configuration validations across the project.
return "", fmt.Errorf("invalid MCP_TRANSPORT: %q (allowed: sse, streamable-http)", mode)
README.md:68
- The documentation now lists 'streamable-http' as a supported value. Please ensure that the configuration examples and usage instructions throughout are updated accordingly.
- Supported values: `sse`, `streamable-http`
dmjb
approved these changes
Jun 20, 2025
JAORMX
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.