Skip to content

Config transport#18

Merged
JAORMX merged 2 commits intomainfrom
config_transport
Jun 20, 2025
Merged

Config transport#18
JAORMX merged 2 commits intomainfrom
config_transport

Conversation

@yrobla
Copy link
Contributor

@yrobla yrobla commented Jun 20, 2025

No description provided.

@yrobla yrobla requested review from Copilot and eleftherias and removed request for eleftherias June 20, 2025 14:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates configuration settings for the MCP server transport mode. The changes include updating the endpoint path to use a trailing slash, renaming the transport mode constant from "http-stream" to "streamable-http" in both code and documentation, and adjusting the error messaging accordingly.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
pkg/mcp/server.go Updated the endpoint path to include a trailing slash.
cmd/server/main.go Changed transport mode constant and corresponding error message.
README.md Revised documentation to reflect the updated transport mode.
Comments suppressed due to low confidence (4)

pkg/mcp/server.go:167

  • The endpoint path now includes a trailing slash, which may change route matching behavior. Please confirm that this change is intentional and consistent with the server's routing requirements.
		server.WithEndpointPath("/mcp/"),

cmd/server/main.go:25

  • The transport mode constant has been updated to 'streamable-http'. Ensure that all parts of the system consuming this constant are updated to avoid inconsistencies.
	TransportHTTPStream TransportMode = "streamable-http"

cmd/server/main.go:38

  • The error message now reflects the updated allowed values. Verify that this update aligns with all relevant configuration validations across the project.
		return "", fmt.Errorf("invalid MCP_TRANSPORT: %q (allowed: sse, streamable-http)", mode)

README.md:68

  • The documentation now lists 'streamable-http' as a supported value. Please ensure that the configuration examples and usage instructions throughout are updated accordingly.
  - Supported values: `sse`, `streamable-http`

@JAORMX JAORMX merged commit e35e9f2 into main Jun 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants