Missing inplace=True parameter in RINEX nav columns renaming#181
Open
FedericoPivotto wants to merge 4 commits intoStanford-NavLab:mainfrom
Open
Missing inplace=True parameter in RINEX nav columns renaming#181FedericoPivotto wants to merge 4 commits intoStanford-NavLab:mainfrom
FedericoPivotto wants to merge 4 commits intoStanford-NavLab:mainfrom
Conversation
Author
|
I have also adjust RINEX nav name convetion to make it compatible with the other library tools. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
=======================================
Coverage 99.66% 99.66%
=======================================
Files 27 27
Lines 3882 3882
=======================================
Hits 3869 3869
Misses 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thanks for using the library @FedericoPivotto and these look like great additions. Sorry I've been traveling and it's taken a bit to check the PR. I should be able to approve and build a new version next week. If you get to it before me, please also add your name to the contributors list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RINEX nav columns X, Y, Z and their deviation are not renamed.
The addition of inplace=True parameter fix the issue.