Migrate spezi health kit by max-rosenblattl · Pull Request #3 · StanfordBDHG/HealthyLLM

max-rosenblattl · 2025-08-24T19:14:11Z

Migrate HealthKit to SpeziHealthKit

♻️ Current situation & Problem

The current implementation doesn't take advantage of SpeziHealthKit.

⚙️ Release Notes

This PR migrates from HealthKit to SpeziHealthKit, improving readability and simplifying the access of health data.

📚 Documentation

This PR mainly refactors the existing implementation
The added extension of HealthQuery should optimally be merged into the SpeziHealthKit framework.

✅ Testing

Tested on iPhone Air.


Workout Info 1	Workout Info 2	Health Data


Time Range Agg. 1	Time Range Agg. 2	Time Range Agg. 3

Code of Conduct & Contributing Guidelines

By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

I agree to follow the Code of Conduct and Contributing Guidelines.

SpeziHealthKit support

max-rosenblattl · 2025-08-24T19:18:23Z

HealthyLLM.xcodeproj/project.pbxproj

 				CODE_SIGN_STYLE = Automatic;
 				CURRENT_PROJECT_VERSION = 1;
 				DEVELOPMENT_ASSET_PATHS = "\"HealthyLLM/Supporting Files/Preview Content\"";
-				DEVELOPMENT_TEAM = CQRZ4E7K9U;


I will revert the development team and bundle identifier after addressing all other PR comments

codecov · 2025-08-24T19:20:14Z

Codecov Report

❌ Patch coverage is 5.00000% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 4.29%. Comparing base (a79c50c) to head (0b9ec99).

Files with missing lines	Patch %	Lines
...lthyLLM/HealthyLLM/Fetcher/HealthDataFetcher.swift	0.00%	13 Missing ⚠️
HealthyLLM/HealthyLLM/HealthDataInterpreter.swift	0.00%	4 Missing ⚠️
HealthyLLM/HealthyLLMAppDelegate.swift	33.34%	2 Missing ⚠️

Additional details and impacted files

@@                    Coverage Diff                    @@
##           feature/add-healthyllm      #3      +/-   ##
=========================================================
- Coverage                    4.43%   4.29%   -0.13%     
=========================================================
  Files                          70      69       -1     
  Lines                         633     630       -3     
=========================================================
- Hits                           28      27       -1     
+ Misses                        605     603       -2

Files with missing lines	Coverage Δ
HealthyLLM/HealthyLLM/HealthyLLMChatView.swift	`0.00% <ø> (ø)`
HealthyLLM/Onboarding/HealthKitPermissions.swift	`16.67% <ø> (ø)`
HealthyLLMStudy/Study/StudyChatView.swift	`0.00% <ø> (ø)`
HealthyLLM/HealthyLLMAppDelegate.swift	`66.67% <33.34%> (-33.33%)`	⬇️
HealthyLLM/HealthyLLM/HealthDataInterpreter.swift	`25.00% <0.00%> (ø)`
...lthyLLM/HealthyLLM/Fetcher/HealthDataFetcher.swift	`6.25% <0.00%> (-13.75%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a79c50c...0b9ec99. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

max-rosenblattl · 2025-08-24T19:24:06Z

HealthyLLM/HealthyLLM/Fetcher/HealthDataFetcher.swift

+
+// One-off query for aggregating health data
+// TODO: Create Pull Request for SpeziHealthKit
+extension HealthKit {
+    public func statisticsQuery<Sample>(


@lukaskollmer do you know if SpeziHealthKit already provides the functionality for one-off statistics queries in some way? If not, and you think it would be useful to others as well, I'm happy to create a PR!

i don't think so; iirc i was planning to create a nice API around HKStatistics (eg so that you dont have to deal with the optional HKQuantity objects that will never be nil) but i didn't get around to it. we do have the @HealthKitStatisticsQuery for SwiftUI; would make sense to add a non-SwiftUI counterpart for one-off queries. we might even be able to reuse the code internally

the @HealthKitStatisticsQuery API already contains an initial attempt at making this type safe; we have different init overloads to prevent the caller from passing in invalid aggregation option combinations

@lukaskollmer and I had a small discussion on Monday about a very simple approach to make the SwiftUI property wrappers also available outside of the SwiftUI hierarchy and usable inside modules, we might want to tackle this in the future, IMO that would solve the issue here as well. But we might want merge this first and then iterate on it later.

Sounds good, @lukaskollmer let me know if you need some support, but for now I agree with merging first and iterating later 👍

@max-rosenblattl Would be great if you could create an issue in SpeziHealthKit that tracks this issue. I also saw that @phnagy was looking into some issues there; maybe that might be a great first issue with a real need and direct implementation pathway. (CC @lukaskollmer)

@lukaskollmer I phrased the issue in a way that suggests implementing your discussed approach; if you have any, it would be great to add some specific details from your discussion that could ease the implementation.

Amazing; thank you @max-rosenblattl!

max-rosenblattl · 2025-08-24T19:34:52Z

HealthyLLM/HealthyLLM/Fetcher/HealthDataFetcher.swift

-                        try? await self.fetchSample(
-                            for: identifier,
-                            unit: unit,
-                            startDate: endDate,
-                            endDate: .now
-                        )


Currently, we’re aggregating time-series data into a single value (e.g., average heart rate over the last month). It might be more meaningful to use a different aggregation approach; for example, retrieving daily averages over the last month instead of just one number. This would also align better with future EmbedHealth integration, even if that’s a larger effort. Let me know what you think @PSchmiedmayer @LeonNissen @lukaskollmer

agree that a higher granularity would be desirable but wasn't the issue here that having too many samples could exceed the context window? (i might be confusing this with something else).

iirc another idea of mine at the time was that we could use different granularities depending on how far back the data was collected (eg weekly heart rate for > a year ago, daily average for > last week, and hourly averages for the past 7 days)

Yes, the main issue was the growing context window; that's why we constrained it to a few samples.

Agree with @lukaskollmer here for this approach. I think 7 days for a week, weekly samples for a month, or monthly samples for a year would make sense and don't dramatically exceed the context window. Would be good to verify this with some on-device testing @max-rosenblattl before we merge this.

Thanks for the insights! I think it makes a lot of sense, happy to tackle that.

Regarding testing on device: I will be able to do so in the very near future; until then if anyone has some spare minutes, I would appreciate it!

Quick update: finally got my new iPhone and could test it on device (results in PR description above)! Also adapted the statistics query to handle the discussed time-range based aggregation intervals. Just saw they were integrated in here too StanfordSpezi/SpeziHealthKit#65 , quite cool looking forward to the merge 🚀

Thank you for working on all of this @max-rosenblattl 🚀

PSchmiedmayer

Thank you for working on this and thank you for your initial comments @lukaskollmer 👍

Happy to see a first version merged once the CI is passing; we will have a decent amount of iterations here when we will embed the time series LLM components but that is a next step after that.

PSchmiedmayer · 2025-08-26T12:52:42Z

HealthyLLM/HealthyLLM/Fetcher/HealthDataFetcher.swift

-                        try? await self.fetchSample(
-                            for: identifier,
-                            unit: unit,
-                            startDate: endDate,
-                            endDate: .now
-                        )


Yes, the main issue was the growing context window; that's why we constrained it to a few samples.

Agree with @lukaskollmer here for this approach. I think 7 days for a week, weekly samples for a month, or monthly samples for a year would make sense and don't dramatically exceed the context window. Would be good to verify this with some on-device testing @max-rosenblattl before we merge this.

PSchmiedmayer · 2025-08-26T12:54:13Z

HealthyLLM/HealthyLLM/Fetcher/HealthDataFetcher.swift

+
+// One-off query for aggregating health data
+// TODO: Create Pull Request for SpeziHealthKit
+extension HealthKit {
+    public func statisticsQuery<Sample>(


@lukaskollmer and I had a small discussion on Monday about a very simple approach to make the SwiftUI property wrappers also available outside of the SwiftUI hierarchy and usable inside modules, we might want to tackle this in the future, IMO that would solve the issue here as well. But we might want merge this first and then iterate on it later.

max-rosenblattl added 12 commits August 10, 2025 22:23

Add basic

d532974

SpeziHealthKit support

Adapt health data fetcher for aggregation

b63460f

Add aggregation support for SpeziHealthKit query

43e43bd

Refactor fetch health

fe0512e

Add parallel processing to fetch health

6d2e475

Refactor user info

ee33e94

Fix health characteristic access

774ef61

Refactor fetch workout

de01a5c

Remove collect samples

3a7a9b0

Refactor health kit authorization

5da5221

Fix statistics query bug

357e83b

Revert debugging tools

8b27fa3

max-rosenblattl commented Aug 24, 2025

View reviewed changes

max-rosenblattl assigned lukaskollmer, PSchmiedmayer and LeonNissen Aug 24, 2025

lukaskollmer assigned max-rosenblattl and unassigned lukaskollmer, PSchmiedmayer and LeonNissen Aug 24, 2025

lukaskollmer requested review from LeonNissen, PSchmiedmayer and lukaskollmer August 24, 2025 19:53

PSchmiedmayer reviewed Aug 26, 2025

View reviewed changes

PSchmiedmayer mentioned this pull request Sep 1, 2025

Idea: Add dedicated APIs for working with non-trivial sample types StanfordSpezi/SpeziHealthKit#54

Open

1 task

phnagy mentioned this pull request Sep 3, 2025

Extend HealthKit Statistics Queries StanfordSpezi/SpeziHealthKit#65

Merged

1 task

Implement time range based aggregation of health records

0b9ec99

Conversation

max-rosenblattl commented Aug 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Migrate HealthKit to SpeziHealthKit

♻️ Current situation & Problem

⚙️ Release Notes

📚 Documentation

✅ Testing

Code of Conduct & Contributing Guidelines

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Aug 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

max-rosenblattl Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PSchmiedmayer left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

max-rosenblattl commented Aug 24, 2025 •

edited

Loading

codecov bot commented Aug 24, 2025 •

edited

Loading

max-rosenblattl Sep 1, 2025 •

edited

Loading

PSchmiedmayer left a comment •

edited

Loading