Skip to content

Convert unit tests to Swift Testing#95

Merged
vishnuravi merged 3 commits intomainfrom
testing
Aug 6, 2025
Merged

Convert unit tests to Swift Testing#95
vishnuravi merged 3 commits intomainfrom
testing

Conversation

@vishnuravi
Copy link
Member

Convert unit tests to Swift Testing

Migrates unit tests which are currently in XCTest to Swift Testing (addresses issue #89)

Code of Conduct & Contributing Guidelines

By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@vishnuravi vishnuravi requested a review from lukaskollmer July 11, 2025 02:48
@codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.22%. Comparing base (ad35779) to head (9c8515a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   86.10%   85.22%   -0.87%     
==========================================
  Files          28       28              
  Lines         489      372     -117     
==========================================
- Hits          421      317     -104     
+ Misses         68       55      -13     
Files with missing lines Coverage Δ
...ests/FHIRPathParserTests/FHIRPathParserTests.swift 100.00% <ø> (+1.57%) ⬆️
...esearchKitOnFHIRTests/FHIRToResearchKitTests.swift 100.00% <100.00%> (+3.51%) ⬆️
.../ResearchKitOnFHIRTests/NavigationRulesTests.swift 100.00% <ø> (ø)
...esearchKitOnFHIRTests/ResearchKitToFHIRTests.swift 100.00% <ø> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad35779...9c8515a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; seems like we need to adjust one more test for it to compile and see that all tests are still succeeding on the CI. Thank you for all the work here @vishnuravi 🚀

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; happy to see this merged once all the CI is passing 🚀

@vishnuravi vishnuravi merged commit c076643 into main Aug 6, 2025
7 checks passed
@vishnuravi vishnuravi deleted the testing branch August 6, 2025 00:12
@github-project-automation github-project-automation bot moved this from In Progress to Done in MyHeart Counts Project Planning Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Development

Successfully merging this pull request may close these issues.

2 participants