Skip to content

Coding: Regex pattern#96

Merged
PSchmiedmayer merged 13 commits intomainfrom
coding-regex-pattern
Jul 22, 2025
Merged

Coding: Regex pattern#96
PSchmiedmayer merged 13 commits intomainfrom
coding-regex-pattern

Conversation

@pauljohanneskraft
Copy link
Contributor

Coding: Regex pattern

♻️ Current situation & Problem

In ENGAGE-HF, we have recently encountered an issue where skip navigation rules didn't work as expected. Unfortunately, my previous changes to include stepIdentifiers in result selectors didn't work as expected and the regex pattern wasn't as expected. Both of these issues should be resolved with this pull request.

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

Code of Conduct & Contributing Guidelines

By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@pauljohanneskraft pauljohanneskraft self-assigned this Jul 21, 2025
@pauljohanneskraft pauljohanneskraft added the bug Something isn't working label Jul 21, 2025
@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.10%. Comparing base (962c2f4) to head (a341c88).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...hKitOnFHIR/FHIRToResearchKit/NavigationRules.swift 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   87.84%   86.10%   -1.74%     
==========================================
  Files          28       28              
  Lines         485      489       +4     
==========================================
- Hits          426      421       -5     
- Misses         59       68       +9     
Files with missing lines Coverage Δ
...es/ResearchKitOnFHIR/ValueCoding/ValueCoding.swift 100.00% <100.00%> (ø)
...esearchKitOnFHIRTests/FHIRToResearchKitTests.swift 96.50% <100.00%> (+0.20%) ⬆️
...hKitOnFHIR/FHIRToResearchKit/NavigationRules.swift 87.50% <0.00%> (-6.25%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 962c2f4...a341c88. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid, thank you @pauljohanneskraft 🚀

@pauljohanneskraft
Copy link
Contributor Author

Please merge this PR - I can't because of the 1 line missing in test coverage... 😅

@PSchmiedmayer PSchmiedmayer merged commit ad35779 into main Jul 22, 2025
6 of 7 checks passed
@PSchmiedmayer PSchmiedmayer deleted the coding-regex-pattern branch July 22, 2025 00:05
@PSchmiedmayer
Copy link
Member

Sure, merged it. Thank you for all the work 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants