Skip to content

improve min/maxValue extraction#97

Merged
lukaskollmer merged 8 commits intomainfrom
lukas/minMaxValue
Oct 17, 2025
Merged

improve min/maxValue extraction#97
lukaskollmer merged 8 commits intomainfrom
lukas/minMaxValue

Conversation

@lukaskollmer
Copy link
Member

improve min/maxValue extraction

♻️ Current situation & Problem

the minValue and maxValue hadling currently only looks at integer values, even for decimal numeric questions.

this PR fixes this, and also makes the code a little nicer along the way

⚙️ Release Notes

  • min and max values for decimal questions are now properly handled

📚 Documentation

n/a

✅ Testing

n/a

Code of Conduct & Contributing Guidelines

By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@lukaskollmer lukaskollmer self-assigned this Oct 16, 2025
@lukaskollmer lukaskollmer added the enhancement New feature or request label Oct 16, 2025
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.72%. Comparing base (c076643) to head (bcb1671).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...earchKitOnFHIR/FHIRExtensions/FHIRExtensions.swift 85.72% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   82.80%   85.72%   +2.92%     
==========================================
  Files          28       28              
  Lines         372      378       +6     
==========================================
+ Hits          308      324      +16     
+ Misses         64       54      -10     
Files with missing lines Coverage Δ
...esearchKitOnFHIRTests/FHIRToResearchKitTests.swift 100.00% <100.00%> (ø)
...earchKitOnFHIR/FHIRExtensions/FHIRExtensions.swift 68.75% <85.72%> (+8.04%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c076643...bcb1671. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid, thank you for all the work here 🚀

@lukaskollmer lukaskollmer merged commit dc3e35d into main Oct 17, 2025
10 checks passed
@lukaskollmer lukaskollmer deleted the lukas/minMaxValue branch October 17, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments