Add OMP_PROC and PY_PROC cases for Realm Processor get_kind_name#1445
Open
brombaut wants to merge 1 commit intoStanfordLegion:masterfrom
Open
Add OMP_PROC and PY_PROC cases for Realm Processor get_kind_name#1445brombaut wants to merge 1 commit intoStanfordLegion:masterfrom
brombaut wants to merge 1 commit intoStanfordLegion:masterfrom
Conversation
Contributor
|
@brombaut thanks for catching this. There's a preprocessor-based way to fix this so that it automatically updates for any other kinds added in the future. I'll put that change in a branch so that you can confirm it solves your original problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just came across these missing cases when I was playing around with the Realm OpenMP module. I checked and didn't find any, but please advise if there are any tests that should also be changed to cover these additions.