Type checking for functions returning regions in Regent#585
Open
ldr709 wants to merge 9 commits intoStanfordLegion:masterfrom
Open
Type checking for functions returning regions in Regent#585ldr709 wants to merge 9 commits intoStanfordLegion:masterfrom
ldr709 wants to merge 9 commits intoStanfordLegion:masterfrom
Conversation
writes(a) and reads(a.x) should be sufficient to grant reduces(a.x), but a bug makes this test case fail.
magnatelee
added
enhancement
planned
Contributor
|
@elliottslaughter @magnatelee what's the plan for this? |
Contributor
|
This depends on #583, and therefore has a similar status. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All permissions and constraints on return values are automatically inferred. It doesn't work for mutually recursive tasks returning regions, though it does for normal recursions. It might be useful to either fix this or allow them to be specified in the task signature.
Code generation for handling the return values is missing, so it will trigger an assertion failure in
codegen.twhen it correctly type checks a region-returning function call.