Open
Conversation
Contributor
|
We'll probably move this over to gitlab for the actual merge, but you can leave it here for now. Assigning @streichler as the primary reviewer since it's mostly Realm related. I looked at the Legion changes and I have no problems with them. |
Author
|
Thanks @lightsighter @streichler pls let us know your thoughts. We can recreate on gitlab once we address your comments. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Posting this PR as an RFC for an Accelerator Module for Realm. The Accelerator could be a local FPGA or a remote node accessible via RPC (think TPU etc).
Please let us know your thoughts and we can revise with your feedback.