Added extraWidth and extraHeight argument for ButtonGlow #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dooez
reviewed
Jan 26, 2022
Collaborator
Dooez
left a comment
Dooez
left a comment
There was a problem hiding this comment.
Functionally changes appear to be fine. Argument names are probably not ideal. 'extraWidth' and 'extraHeight' seem unintuitive for negative values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in this WeakAuras/WeakAuras2#3454 feature request, it would be nice to be able to resize ButtonGlow in certain situations without having to rely on Masque skins.