fix: skip breakpoint/other exceptions on aarch64 to match Linux behavior#96
Closed
yoinspiration wants to merge 2 commits intoStarry-OS:mainfrom
Closed
fix: skip breakpoint/other exceptions on aarch64 to match Linux behavior#96yoinspiration wants to merge 2 commits intoStarry-OS:mainfrom
yoinspiration wants to merge 2 commits intoStarry-OS:mainfrom
Conversation
- Handle ExceptionKind::Breakpoint by skipping instruction on aarch64 - Handle ExceptionKind::Other by skipping instruction on aarch64 - Fixes ffmpeg --help crash with 'Trace/breakpoint trap' on aarch64 - Matches Linux behavior where breakpoint instructions are ignored when not debugged
Open
AsakuraMizu
requested changes
Dec 20, 2025
Contributor
AsakuraMizu
left a comment
AsakuraMizu
left a comment
There was a problem hiding this comment.
Hacking here is clearly inappropriate, and breakpoint exceptions also exist in other architectures. In reality, we haven't considered this behavior yet. Please modify axcpu.
On another note, your mention of may be reported as "Other" instead of "Breakpoint" is also due to a typo in axcpu; the correct exception type is Brk64, not BreakpointLowerEL.
You might refer to the relevant code at https://github.com/Starry-OS/axcpu/tree/dev/axprobe, but we don't need BREAK_HANDLER yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47