Fix PWA white screen: correct manifest.json path typo

[Copilot]

Pull Request Template

Overview

PWA displayed white screen when installed to homescreen due to manifest validation error.

• Bugfix
• Feature
• Code Refactor
• Documentation Update
• Broker Integration Enhancement
• Analytics/Metrics Enhancement
• UI/UX Improvement
• Performance Optimization
• Trading Strategy/Framework Update
• Automation/Workflow Improvement
• Other (describe below)

Description

Manifest contained incorrect base path /Personal-Pennies/ in Analytics shortcut (line 64), causing PWA installation failure. Fixed to /SFTi-Pennies/ to match repository path.

Investigation of working Personal-Pennies repo confirmed simple relative path approach is sufficient—service worker and base tags unnecessary for GitHub Pages PWA.

// manifest.json line 64
{
  "name": "Analytics",
  "short_name": "Analytics",
  "description": "View trading analytics and performance metrics",
- "url": "/Personal-Pennies/index.directory/analytics.html",
+ "url": "/SFTi-Pennies/index.directory/analytics.html",
  ...
}

Related Issues

Closes #[issue-number]

Changes Made

• Configuration changes
• Frontend changes (HTML/CSS/Vanilla JavaScript)
• Python automation scripts
• GitHub Actions workflows
• Trading templates (trade.md, weekly-summary.md)
• Analytics/chart generation
• CSV import/export functionality
• Broker integration (IBKR/Schwab/Robinhood/Webull)
• Documentation updates

Testing Checklist

• JavaScript builds successfully (npm run build)
• Python scripts run without errors
• Local development server works (python -m http.server 8000)
• Application loads at http://localhost:8000/
• GitHub Pages deployment tested (if applicable)
• Core functionality tested manually in browser
• Trade submission and processing verified
• Analytics calculations verified (if applicable)
• CSV import/export tested (if applicable)
• Mobile responsive design verified
• PWA installation tested (if applicable)

Screenshots / Evidence

Testing post-merge required: install PWA to homescreen, verify shortcuts work.

Broker Integration Impact

• No broker integration changes
• Enhanced broker CSV import
• New broker support added
• Broker parsing improvements
• Multi-broker compatibility maintained

Analytics Impact

• No analytics changes
• New metrics added
• Chart visualization improvements
• Calculation accuracy improvements
• Performance metrics updates

Breaking Changes

• No breaking changes
• Breaking changes (describe below)

Additional Notes

Removed during implementation:

• Service worker (sw.js) - not required for PWA functionality
• Base tag experiments - relative paths sufficient per working Personal-Pennies setup

Security: CodeQL scan passed, no vulnerabilities introduced.

---

Reviewer Checklist:

• Code follows project standards
  • Python code follows PEP 8 guidelines
  • JavaScript follows vanilla JS best practices
• Changes are well-documented
• No sensitive data exposed (PATs, account numbers, API keys)
• Trade data integrity maintained
• Analytics calculations are mathematically correct
• UI changes are responsive and accessible
• Mobile PWA functionality preserved
• GitHub Actions workflows validated

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[BUG] PWA system has a Pitfall</issue_title>
<issue_description>## 🐛 Summary

When adding the Github Pages hosted PWA to homescreen, it adds the logo properly yet the actual pwa just opens a white screen, yet in browser it shows the full pwa, what is wrong with the pathing in the PWA system? Please find and patch</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes [BUG] PWA system has a Pitfall #168

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[Copilot]

Pull Request Overview

This PR fixes a critical PWA white screen issue caused by a single typo in the manifest.json file. The Analytics shortcut was pointing to the wrong repository path (/Personal-Pennies/ instead of /SFTi-Pennies/), which prevented the PWA from loading correctly when installed to the home screen.

• Corrected the Analytics shortcut URL in manifest.json from /Personal-Pennies/ to /SFTi-Pennies/

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.