Improved detection for FishNet multiplayer library #883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix non-capturing group test.
Author
|
Member
|
Why isn't the dll enough? |
Author
|
The dll only returns results for Mono builds, which a significant amount of
releases due not use because Mono is slower and much easier to disassemble.
This additional will add detection for IL2CPP as well.
…On Sun, Jul 13, 2025, 4:19 PM Pavel Djundik ***@***.***> wrote:
*xPaw* left a comment (SteamDatabase/FileDetectionRuleSets#883)
<#883 (comment)>
Why isn't the dll enough?
—
Reply to this email directly, view it on GitHub
<#883 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGPJC3RN3VPUPHX4AZZYBYL3IK5NPAVCNFSM6AAAAACBL5UYXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANRXGI4DAMZQGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
I don't really like that it's such a generic name like "BuildInformation", is there nothing better available? EDIT: Bot says this doesn't match anything new. |
Member
|
After running changed rules in this pull request (this bot only tests rules.ini changes): Changed technologies: SDK.FishNet 230 apps still match. Please confirm that all these changed apps are correct. |
Author
|
We can leave out the just at 'BuildInformation' one and only use the
'F##BuildInformation'.
The file would also always be in root. I can change the file type as well
to something really unique. I did not want to put 'FishNet' in the same
specifically to avoid easy identification for would be exploiters -
although realistically they could still just peek the metadata.
I have not put in the change with the 'F##BuildInformation.json' yet.
what about 'F##Build.SDK.id' or something of that sort?
…On Mon, Jul 14, 2025, 8:13 AM Wendy ***@***.***> wrote:
*SteamDB-Tracker* left a comment (SteamDatabase/FileDetectionRuleSets#883)
<#883 (comment)>
After running changed rules in this pull request *(this bot only tests
rules.ini changes)*:
Changed technologies: *SDK.FishNet*
*230* apps still match.
Please confirm that all these changed apps are correct.
—
Reply to this email directly, view it on GitHub
<#883 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGPJC3WFX5FIWYOVAZBRLAT3IONFHAVCNFSM6AAAAACBL5UYXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANRZGI2TOMZQGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
It's probably best to make the file name static and just put the full name in it, not try to obscure it with a single letter. I will close this PR for now, you can make a new one when games ship with it. |
Author
|
I would like to still keep in the numbers as that shows the major version
of the release. Each major version is typically only done once a year and
is a big milestone, so it would be nice to know which games were on what
versions. It is not a necessity however. I will make a new PR with the
changes when I can confirm a game is launched on a version of FishNet which
has the indicator.
Thanks!
…On Mon, Jul 14, 2025, 9:12 AM Pavel Djundik ***@***.***> wrote:
Closed #883
<#883>.
—
Reply to this email directly, view it on GitHub
<#883 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGPJC3RAIVQ37U3DOLCBAJL3IOUCPAVCNFSM6AAAAACBL5UYXOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJYGYYTOOJUGAZTMNY>
.
You are receiving this because you authored the thread.Message ID:
<SteamDatabase/FileDetectionRuleSets/pull/883/issue_event/18617940367@
github.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT
This change uses cross-platform path detection for Windows, Mac/Linux builds. Please tests to ensure games using FishNet.Runtime.dll appear before accepting. BuildInformation detection may not find any releases yet as this was only recently added to FishNet.
SteamDB app page links to a few games using this
Detection will only find releases on Mono and more recent versions of FishNet.
Detection
FishNet.Runtime.dll
BuildInformation.json
F01BuildInformation.json
Brief explanation of the change
FishNet now adds an identifier to builds to be able to quickly identify if a build is using FishNet in both Mono and IL2CPP releases.
Notes:
Either BuildInformation.json or F##BuildInformation.json will be found in root, along with the game executable. These identifiers are added at build-time by FishNet.
BuildInformation.json an identifier introduced several months ago.
F##BuildInformation.json is a new identifier to determine the major version of FishNet, as well reduce likeliness of a false-positive.