Removed FocusRing from Decky Changelog Modal and use Focusable instead which fixes: #685#779
Merged
TrainDoctor merged 2 commits intoSteamDeckHomebrew:mainfrom Jun 29, 2025
Conversation
ynhhoJ
commented
Jun 2, 2025
|
|
||
| const Markdown: FunctionComponent<MarkdownProps> = (props) => { | ||
| const eventDetailsBodyClassName = findClassByName('EventDetailsBody') || undefined; | ||
| const eventLinkClassName = findClass('43088', 'Link'); |
Contributor
Author
There was a problem hiding this comment.
findClass & findClassByName was moved to head of method to avoid unnecessary search of class names for each a tag.
Member
There was a problem hiding this comment.
might be better to just move them outside the component tbh
ynhhoJ
force-pushed
the
bugfixes/changelog-modal
branch
from
2737733 to
61c8b04
Compare
Member
|
@ynhhoJ, I will be merging this soon. If you can make the suggested optimization AA requested I'd appreciate it. |
chenx-dust
pushed a commit
to chenx-dust/decky-loader
that referenced
this pull request
Dec 22, 2025
…stead which fixes: SteamDeckHomebrew#685 (SteamDeckHomebrew#779) * fix(Updater): Remove `FocusRing` component and use `Focusable` instead * feat(Markdown): Add Link `class` to a tag for a mentain a Steam UI colors palette
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please tick as appropriate:
If you're wanting to update a translation or add a new one, please use the weblate page: https://weblate.werwolv.net/projects/decky/
Description
This fixes issue: #685
Was removed
FocusRingcomponent and used justFocusableinstead, and I modified a little bit UI to be more Steam UI like