-
Notifications
You must be signed in to change notification settings - Fork 221
Improved error screen #841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Improved error screen #841
Conversation
|
@jessebofill Any chance this screen could include buttons to check for plugin updates as well? |
- Removed gray text class usage - Removed styles reminiscent of Steam BPM - Fixed typos
- Change background/text of buttons to be closer to Steam Deck UI - Make panel background not reliant on transparency and have a neutral gray - Bold "likely occurred" text - Make swipe prompt appear in the center of a horizontal bar, drawing more attention to it - Make "An error occurred" text smaller, as it isn't helpful for troubleshooting - Add text clarifying solutions are in recommended order and how to get more help - Add "Retry the action or restart" to the left of Retry, Restart Steam, and Restart Decky buttons - Move disabling Decky to beneath the Decky update checking
|
Changed style a bit to be more consistent with Steam Deck UI while keeping a black background to show a clear visual difference from the rest of the app. Will finish collaborating on this PR once #850 is merged.
|
|
Just an idea: what if there is a plugin mentioned in the error trace, could the text for it be rendered in bold so it's easier to spot for troubleshooting? Though it seems like the main header contains the plugin name already so... (don't know if its possible that multiple plugins error out at once) For example: TRACE Apart from that I think tiny bit more contrast between the various backgrounds and separating lines would be nice as well. |
|
@EMERALD0874 If there's still time to make one last change, would it be possible to include an "update plugins" button? Or is that already covered under "check for updates"? |
|
We would likely have to fire a web request to check if the plugin is even on the Decky Store. I don't think it's a good idea as the error boundary should be as local as possible. |
|
@jessebofill The disable plugin PR has been merged. Would you mind implementing that in your error screen and running the linter? |
Awesome! |
86415b4 to
84bbb29
Compare
|
Ok disabling buttons are implemented. |
|
@EMERALD0874 fyi, idk why your screenshots are black, but mine were like this. It probably depends on where the error occurs.
So I assume the background is transparent as it is now, which imo doesn't look terrible. But if you want it black you should set it explicitly under this selector |
|
@jessebofill Yes, I'd prefer it to be black. Probably CSS Loader creating some confusion on my end. I'll be away from my dev environment for a while if you'd like to fix it so I can deploy for testing. Otherwise, I'll do it in a few hours or tomorrow. |
|
I also won’t be able until later today. If I get to it first I will. |
EMERALD0874
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for testing




Please tick as appropriate:
If you're wanting to update a translation or add a new one, please use the weblate page: https://weblate.werwolv.net/projects/decky/
Description
This is a proof of concept of how to improve the visuals of the error screen, to hopefuly make it more encouraging for users to read the options and try them if have a problem.
This also adds buttons for disabling plugins to the screen. They are just placeholder buttons which are currently commented out, but they would be able to easily be wired up for that functionality if/ once implmented (which I have another pr for #850 )
Feel free to do what you like with this idea, build upon or just take inspiration from.