Notify password length and add error for password on non standard ASCII.#1515
Closed
Alstruit wants to merge 3 commits intoSteamRE:masterfrom
Closed
Notify password length and add error for password on non standard ASCII.#1515Alstruit wants to merge 3 commits intoSteamRE:masterfrom
Alstruit wants to merge 3 commits intoSteamRE:masterfrom
Conversation
Steam will only accept password length up to 64 characters.
Co-authored-by: Pavel Djundik <xPaw@users.noreply.github.com>
Member
|
I'm not really a fan of doing this in the library (this also misses this in SteamUser.LogOn btw), especially because without replacing non-ascii characters like Valve does this logic isn't entirely correct. |
yaakov-h
reviewed
Mar 3, 2025
Member
yaakov-h
left a comment
yaakov-h
left a comment
There was a problem hiding this comment.
I think we should just log the warning but not trim.
Any consumer can trim at any point, but if Valve change their behaviour I don't want consumers to need to upgrade before they can log back in.
Alstruit
changed the title
Author
|
On the Unicode part. Steam does display an error if the password is not standard ASCII. |
Alstruit
force-pushed
the
password_64_library
branch
from
209a189 to
7baed81
Compare
Alstruit
force-pushed
the
password_64_library
branch
from
7baed81 to
000e54c
Compare
Notify password length is greater 64. Throw an error since Steam does reject non standard ASCII characters.
Alstruit
force-pushed
the
password_64_library
branch
from
000e54c to
e700ecb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steam will only accept password length up to 64 characters.
Reference:
SteamRE/DepotDownloader#601
SteamRE/DepotDownloader#597