Streamline G.viewed_stake logic #1081
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for
G.viewed_stakecan be streamlined into the following 4 cases:all_unlocked), nothing else matters and any stake can be viewed.SMODS.check_applied_stakes, a stake is considered available if it exists without depending on any applied stakes, or if it has applied stakes, all of them have to be beaten beforehand.An additional check to see if a stake is unlocked could be done, but I have failed to catch any edge cases after repeated manual tests. Therefore, a check for applied stakes should suffice.
This should also work for multiple stakes that could be available right from the start of a new profile (e.g. several variations of the White Stake).
Additional Info: