Skip to content

Add dark mode#344

Closed
TimHess wants to merge 3 commits intov4from
darkmode
Closed

Add dark mode#344
TimHess wants to merge 3 commits intov4from
darkmode

Conversation

@TimHess
Copy link
Member

@TimHess TimHess commented Feb 3, 2025

Now also available for testing at https://docs-dark.steeltoe.io/ because I'm experiencing what seemed to be a cookie-related issue where theme choice is lost after clicking around to other pages... But that was not the problem - might be that the selection is put in local storage instead of a cookie. Leaving this up anyway for feedback on the dark theme and because I jumped through extra hoops to map a .steeltoe.io name for it

@github-actions
Copy link

github-actions bot commented Feb 3, 2025

Preview link: https://docs-steeltoe-pr-344.azurewebsites.net

  • Your changes have been deployed to the preview site. The preview site will update as you add more commits to this branch.
  • The preview link is shareable, but will be deleted when the pull request is merged or closed.

This is an automated message.

@bart-vmware
Copy link
Member

The toggle doesn't stick at https://docs-dark.steeltoe.io/ either.

Readability issue:
image

Perhaps it's just me, but I find reading the regular color settings peaceful and professional. The dark mode comes across to me as very screamy and aggressive. Compare this with https://www.jsonapi.net/usage/reading/filtering.html, which uses the DocFx default light/dark themes, which are both peaceful.

Can't we just use a generic transform such as here instead of restyling many elements? See also https://radu-matei.com/blog/dark-mode/.

@TimHess
Copy link
Member Author

TimHess commented Feb 4, 2025

The toggle doesn't stick at https://docs-dark.steeltoe.io/ either.
Yeah, already noted. There are a couple places in our JS that clear local storage which is probably the reason it doesn't stick, but I've no idea why it does that.

Readability issue: image

Perhaps it's just me, but I find reading the regular color settings peaceful and professional. The dark mode comes across to me as very screamy and aggressive. Compare this with https://www.jsonapi.net/usage/reading/filtering.html, which uses the DocFx default light/dark themes, which are both peaceful.

Can't we just use a generic transform such as here instead of restyling many elements? See also https://radu-matei.com/blog/dark-mode/.

I didn't author these commits (just rebased/re-applied them). I also don't love the theme and the readability issue you pointed out probably isn't the only one and I think is part of why the effort stalled out originally

@bart-vmware
Copy link
Member

I didn't author these commits (just rebased/re-applied them). I also don't love the theme and the readability issue you pointed out probably isn't the only one and I think is part of why the effort stalled out originally

Well, I'm in favor of keeping things as-is for now and revisiting dark mode when updating to the latest DocFX version.

@TimHess
Copy link
Member Author

TimHess commented Feb 26, 2025

will revisit with docfx update

@TimHess TimHess closed this Feb 26, 2025
@bart-vmware bart-vmware deleted the darkmode branch February 26, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants